Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font awesome gitlab icon not displayed in footer #71

Closed
thomasboni opened this issue Sep 3, 2019 · 2 comments · May be fixed by #77
Closed

Font awesome gitlab icon not displayed in footer #71

thomasboni opened this issue Sep 3, 2019 · 2 comments · May be fixed by #77
Labels
bug Something isn't working

Comments

@thomasboni
Copy link

Gitlab icon is avaible on font awesome (https://fontawesome.com/v4.7.0/icon/gitlab/).

But when I try to use it in this theme it doesn't work:

footer:
     # Logo (from /images/logos/___)
     logo: fresh-white-alt.svg
     socialmedia:
       # Icons are from Font Awesome
     - link:  "#"
       icon: github
     - link: "#"
       icon: gitlab
     - link:  "#"
       icon: twitter

Github and Twitter works fine but gitlab doesn't works (display nothing). Maybe I miss some step ?
@nathanbiller nathanbiller mentioned this issue Sep 27, 2019
Open
@nathanbiller
Copy link
Contributor

nathanbiller commented Oct 3, 2019 •
edited

@thomasboni The font-awesome package this theme is currently using is v4.6.3 Because they've rewritten their package from the ground up I updated what we were using to the current version and verified that gitlab does work there. So once @StefMa verifies and merges your icon should begin working but will require you to make a few tweaks to the config file. You'll now need to specify the full class like "fab fa-gitlab"

@StefMa StefMa added the bug Something isn't working label Feb 12, 2021
@StefMa
Copy link
Owner

StefMa commented Jan 19, 2023

Issue marked as obsolete due to lack of activity.
If you still think this is an issue, please reopen this issue or create a new one.

@StefMa StefMa closed this as completed Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to Font Awesome 5.11.2 nathanbiller/hugo-fresh
3 participants
@thomasboni @StefMa @nathanbiller