-
-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSO/SAML support #5625
Comments
@pimguilherme This demo part looks great. I wanted to test out SSO login, but couldn't find any proper implementation method, however this looks like a good start. A few questions:
|
thanks for the input @rush-skills ! 1 - not yet... i have not looked into the RBAC handling on stackstorm, but if it is as simple as I think it might be, it would just be a matter of mapping groups to roles from the SSO backend (so just a config in the backend should do it) 2 - it should work in parallel to ldap but I am not sure.. the SSO backend as it's currently implemented is parallel to the standard auth mechanisms
this is more or less what goes on.. in the CLI case there's this encryption key, but in the web case I think we just need to do some cross-site request checks, but that's still to be implemented and validated |
@pimguilherme These steps seem good to me. Can you open your PR(s) and I can review the code/test the feature and come back at you better |
Hi @rush-skills ! Thanks for getting back to me :) I will create the PR in the code this week and let you know! Cheers |
Hey @pimguilherme |
Hey @rush-skills ! Thanks for reaching out.. unfortunately I did not make any progress as there were other internal priorities in the company.. many of them involved in internal stackstorm automations but this PR got a bit of a halt.. gladly we should be putting more effort into it starting this week.. hopefully to resolve and finish it :) Here are our prs:
Some next items to be followed up on:
Cheers! |
Hey @pimguilherme That looks great and a lot of effort. Thanks for the contribution! If you can start adding more docs and descriptions to the PR, I can try setting them up next week and testing the changes. |
Thanks for the feedback @rush-skills ! It's still not fully done as automated tests and some tweaks here and there are still needed, but it can definitely be tested manually as as starting point.. I am finally going to work on in again this week, so I will provide some more updates and all cheers :) |
hey @rush-skills , I am starting by trying to make tests here: are you familiar with this code? it looks like the makefile is broken and it doesn't look like other st2-auth-backend modules use a Makefile in general.. I just wanted to check before doing any changes, otherwise I will just try to tinker around and make it work cheers! |
Haven't got much experience, but indeed the tests are broken for the repo. From what I see, it still uses CircleCI (we are migrating to GitHub Actions now) with Python 2 build (which again is deprecated). I can try creating an issue and picking it up later, but that won't be soon I guess. Feel free to tinker around and change the tests however you want in the meanwhile. |
hi @rush-skills ! I have deleted some old comments and compiled the latest status: To implement this change I had to update the following repositories:
to test this, you should:
to test the st2cli:
i think this is pretty much it!! please let me know cheers! |
@pimguilherme Wow, this is a lot of work. Thanks for the update! I haven't got the chance to test these changes yet, will try to follow the instructions and test them next week. Cheers, |
sounds good @rush-skills , thanks! :) I was able to validate the steps worked, and I will keep on working further on this and should very soon be fully done.. in any case the testing steps should be working in the meantime cheers! |
hi @rush-skills @cognifloyd @armab (tagging some people I see are quite active around here :) I just wanted to follow up on this PR.. would you be able to help us merge it? I think it's basically ready, pending basically some docs, and some help on getting the CI to pass Please let me know if there's anything I can do to help thanks! |
Hey @pimguilherme. Apologies, I had been on leave during the summer and didn't get a chance to test it out. In the meanwhile, if you need any specific help with CI, feel free to point out the errors and one of us will have a look and try to get it sorted. |
Hey @rush-skills , thanks! I will work on updating the docs and the CI, and also make myself available to help on whatever you guys need to test it out (perhaps following the instructions on one of the last posts could be a starting point for some initial tests) The CI was passing a few weeks ago, so it is probably related to some recent changes.. probably also not something very big.. I will try to work it out and reach out if needed Cheers! |
Hi @rush-skills ! Further updates.. I think things are 100% ready for the merge :) CIs are passing and DOC has been updated I have updated the summary comment a few comments back with all the PRs Please let me know if theres any further help I can provide Cheers! |
Hey @pimguilherme So I am finally having a look at this and starting to test the PR(s). I will do the docker testing followed by testing the core packages later. For now, the first issue I face is when I run
I get
|
oh thatś great to hear @rush-skills ! :D i have merged the code with the master branch and released the circle CI packages again, and then updated them in the docker files (that's what was failing, because they were purged I think) can you please try it from scratch? I have also updated the notes with how to test the st2 client as well Cheers! |
Hi guys! Checking to see if there was any luck here and anything I can do to help Cheers! |
Our org is migrating to Okta for SSO, and this is a critical feature for our continued use of Stackstorm. Is there an ETA for this feature becoming available? |
Hi @cydergoth ! happy to see interested parties here :) we have been using this branched implementation of SSO in our company and it's been working well.. we still need the stackstorm maintainers to help us merge this into the main code to get it all worked out.. @rush-skills is helping us on that but I think he has a bit on his plate now I would requested you to try it out following the steps at the end of this comment: #5625 (comment) if you need any help setting it up, I would love to help (you could try to point the SSO backend to your company's OKTA setup (provided its saml) to see if the current proposal will help you) thanks! |
@pimguilherme I'm definitely interested in testing out this SSO/SAML implementation. It should be a lot smoother than the solution I hacked together with OAuth2-Proxy. I should have some time next week to set this up in our development environment and do some thorough testing. Thank you and your team for getting this together. |
that's great to hear @thozook ! initially we also hacked something together just to get it working and now we were able to dedicate some time to get it into the community :) your help testing will be of great value, cheers! if you have any questions please let me know \o |
Hi all, nice to see this has.kicked off some interest as we like ST2 :-) I am busy dealing with a certain OpenSSL issue but I will try to carve out some time next week to test this. Not sure what ingress controller we will be using, possibly Istio |
💯 More testing and feedback would be highly appreciated. At this moment the release team is preparing the |
@pimguilherme Thank you for those screenshots, they helped me find out what was incorrect in my settings. I had left the Attributes and Claims section to the default settings on Azure. After adjusting it to match what you have setup, the SSO flow worked perfectly for me. I was even able to remove the settings for "want_response_signed" and "want_assertions_signed" after setting the SAML signing option to sign both the response and assertion. |
that's great to hear! :) if you have any other issues please report them \o |
Do these clarifications need to be added the st2docs PR to avoid such confusion in the future? |
I think it's worth adding as we find out some of these examples, but in the end we provide a bit of a "generic" interface to saml configuration and the tweaking / adjusting of particular setups is more in the hands of the admin (hoping these generic configs are enough to provide any tweaking needed) Some things are definitely worth documenting like the need of the claim being Username.. I will update the docs! -- EDIT: done! not all checks are passing due to some readthedocs check, but apparently all PRs are the same.. so letting that aside for now |
Your https://output.circle-artifacts.com/output/job/9492f18c-c1f6-4232-a3a7-a45a9e5423bc/artifacts/1/packages/focal/st2_3.8dev-1_amd64.deb this link from file st2-dockerfiles/base/Dockerfile is not work same issue in st2web. Can I get updated link? |
Hey! I will rebuild it later today and update the ticket!
…On Fri, Feb 24, 2023, 11:12 sidharth61 ***@***.***> wrote:
Your
https://output.circle-artifacts.com/output/job/9492f18c-c1f6-4232-a3a7-a45a9e5423bc/artifacts/1/packages/focal/st2_3.8dev-1_amd64.deb
this link from file st2-dockerfiles/base/Dockerfile is not work same issue
in st2web. Can I get updated link?
—
Reply to this email directly, view it on GitHub
<#5625 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKXPJJFCDG2CYS6DXMPBHDWZC6V7ANCNFSM5T5JLGXQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@pimguilherme thanks foe quick help. https://output.circle-artifacts.com/output/job/64165511-269a-489e-b3cf-a9e122879408/artifacts/0/packages/focal/st2web_3.8dev-1_amd64.deb link inside st2-dockerfiles/st2web/Dockerfile (feat/saml-test). |
sure! I have rebuilt them @sidharth61 , thanks :) @nzlosh @armab @cognifloyd do you think this is still going to make 3.9.0? |
I'm focused on revamping the developer tooling around contributing to StackStorm, so I'm having a hard time switching focus to reviewing other changes in ST2. But, Improving SSO is an awesome thing, so I do want to see you work merged ASAP, preferably in 3.9. Please ask for PR reviews in #development on slack. If no one responds after a few days to a week (time for people across time zones to see it), post again in the #tsc channel. |
Got it! Will do, thanks @cognifloyd ! I will try to engage people on those channels Cheers! |
Is SSO officially supported in st2 v3.8.0? I don't see it specified in the release notes: However, I see that it's part of the config file for the tagged v3.8.0 release: This release note mentions that SSO/SAML support with be part of the next release: |
@pimguilherme for Azure AD for entity_id I am using my domain name with port number. I am getting error "{"faultstring":"Invalid referer -- it should be either some localhost endpoint or the SSO configured entity"}" I am not localhost as you used in config. Do I also have to use localhost instead of my domain name? |
Hi @rite2hhh ! SSO was partly implemented in 3.8.0 (it was done so a while ago), but it was never really fully supported.. The foundation for SSO was there but no specific SSO mechanism was fully implemented. This PR aims to implement the SSO backend + SAML fully for usage. if you are looking for SSO/SAML in stackstorm, it would be very helpful if you could test it out with these steps and see if it works for you :) Cheers! @sidharth61, I think you should use the domain/port combination that is used by your users to access stackstorm. Can you please confirm that's the case? And then you should also configure it in Azure AD like this: Cheers! |
@pimguilherme I need instruction for enabling ssl. For azure sso I need this ssl enabled. Don't find any documentation. I made some changes but not working for me.i also generated ssl cert using code that is provided to create free certificate and enabled ssl option. |
Hi @sidharth61 ! You should be able to use SSL normally.. in the example above there is SSL enabled (https://stackstorm.homolog.etc). Can you confirm if you have been able to configure stackstorm to serve using SSL? This depends a lot on how you are deploying Stackstorm Thanks! |
@pimguilherme I enabled ssl by changing this ST2WEB_HTTPS: ${ST2WEB_HTTPS:-0} in file st2-docker/docker-compose.yml. Also enabled - "${ST2_EXPOSE_HTTPS:-127.0.0.1:443}:443" this and changed ip address from 127.0.0.1 to 0.0.0.0 , copied ssl certificate in folder /etc/ssl/st2 inside st2web container. After this restarted nginx service and st2web container started showing error. |
@pimguilherme can you provide me steps how to enable ssl. After I enabled ssl in st2web I am getting ssl issue with st2api baseurl. |
@cognifloyd need help with ssl. I deployed stackstorm container. Enable ssl for st2web as it is described in s2web dockerfile and generated free ssl. But getting issue with api url redirecting to 308. What other changes should I do to make ssl work . Attest provide some documentation for enabling ssl for docker |
@pimguilherme I deployed stackstorm like you described in this thread. I changed ip from 127.0.0.1 to 0.0.0.0 . Enabled ssl option st2web as you have described and generated free ssl using given code but getting issue on line 141 in nginx config st2.conf. That has url related to st2auth. Can you tell if I have to enable ssl in other containers also. I need help in this issue. |
+1 for interested parties here. I have been running automation with stackstorm-ha deployed in AWS at my org for the past 6 months and it has been working great. The worst part is user management, so SSO would be amazing. Let me know if I can do anything to help. |
I am looking to integrate aws cognito with st2 for SSO, do we have any documentation on SSO set up yet? I have st2 set up in AWS EKS, so I am unclear how I can update SSO configs for st2, is that supported yet? |
You can follow #5625 this for sso
…On Mon, Mar 11, 2024 at 5:47 PM rrahman-nv ***@***.***> wrote:
I am looking to integrate aws cognito with st2 for SSO, do we have any
documentation on SSO set up yet? I have st2 set up in AWS EKS, so I am
unclear how I can update SSO configs for st2, is that supported yet?
—
Reply to this email directly, view it on GitHub
<#5625 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABEK5FAQKEMZZECSA7PBRYLYXWOFLAVCNFSM5T5JLGX2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJYHAZTAOBQHA4Q>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
This solution worked for me
On Tue, Mar 12, 2024 at 1:27 AM sidharth singh ***@***.***>
wrote:
… You can follow #5625 this for sso
On Mon, Mar 11, 2024 at 5:47 PM rrahman-nv ***@***.***>
wrote:
> I am looking to integrate aws cognito with st2 for SSO, do we have any
> documentation on SSO set up yet? I have st2 set up in AWS EKS, so I am
> unclear how I can update SSO configs for st2, is that supported yet?
>
> —
> Reply to this email directly, view it on GitHub
> <#5625 (comment)>,
> or unsubscribe
> <https://github.com/notifications/unsubscribe-auth/ABEK5FAQKEMZZECSA7PBRYLYXWOFLAVCNFSM5T5JLGX2U5DIOJSWCZC7NNSXTN2JONZXKZKDN5WW2ZLOOQ5TCOJYHAZTAOBQHA4Q>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
Hi @pimguilherme, First and foremost, this PR is very helpful and it's surely a lot of work. Thanks for your contribution. But I'm getting the below error:
I noticed that the same issue was reported by @rush-skills, here: #5625 (comment) Looks like the .dep package is no longer available at the source, do you know how can I make this work? |
hey @ArpanBalpande, thanks for reaching out! I remember I used to build this package through Circle CI and reference its artifact link.. I will try to rebuilt it today and capture the steps |
Solution worked for me as well. |
Hi dear stackstorm maintainers/community!
I've been working on a PR to implement SSO/SAML using whatever we currently have as a base (st2-auth-backend-sso-saml2) and some other bits and pieces of SSO through the main st2 repository.
I asked around in slack if this had any traction and apparently not, so I just went ahead and started implementing some of it because we need that for our strategy at the company I work for.
Are there any other guidelines regarding contribution other than these items?
https://github.com/StackStorm/st2/blob/abb694b85f75dc543ecea7df6b87def4bce53309/CONTRIBUTING.rst
https://docs.stackstorm.com/development/index.html
I am currently focusing on getting it working on manual tests and will write proper tests afterwards, but can I count on some assistance to further validate/refine this as it progresses?
here's a bit of how it looks so far..
https://user-images.githubusercontent.com/1406885/164324464-29150514-1b5c-415d-bb71-d1e5f2cf568a.mp4
if you have any SAML/SSO material, that would be lovely as well.. currently I've been trying to base the implementation off gravitational/teleport
thanks!!
The text was updated successfully, but these errors were encountered: