Fix py3.6 build by pinning the container to Ubuntu 20.04 #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzlosh
reviewed
Aug 15, 2023
| @@ -12,13 +12,15 @@ jobs: | |||
| # assuming that any pull requests from the same repo are infra changes. | |||
| if: github.event.pull_request.head.repo.full_name != github.repository | |||
|
|
|||
| runs-on: ubuntu-latest | |||
| # As long as we need Python 3.8 here in the test, we can only use up to Ubuntu 20 | |||
There was a problem hiding this comment.
Should that read Python 3.6 instead of Python 3.8?
There was a problem hiding this comment.
Yep! My bad, thanks for the 👀
Fixed in 6dc3192
|
minor nit-pick on comment, but otherwise LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix the CI build (failing on the new pack contribution #179)
It seems the py 3.6 is not available in the
ubuntu-latestGHA container, - pin it to Ubuntu 20.4.