Skip to content

Improve compatibility of PopPUNK v2.7.8 (x86-64-v3 instruction set)#1672

Merged
Kincekara merged 2 commits intoStaPH-B:masterfrom
HarryHung:master
Apr 30, 2026
Merged

Improve compatibility of PopPUNK v2.7.8 (x86-64-v3 instruction set)#1672
Kincekara merged 2 commits intoStaPH-B:masterfrom
HarryHung:master

Conversation

@HarryHung
Copy link
Copy Markdown
Contributor

  1. Force the conda solver to use x86-64-v3 instruction set to resolve compatibility issue mentioned in [Bug]: PopPUNK v2.7.8 - Illegal instruction #1631
  2. Update links in the README.md
  3. Superseded Improve compatibility of PopPUNK v2.7.8 #1670 by having this build as a new image.

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number in build-files (i.e. docker-builds/build-files/spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. build-files/shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. docker-builds/build-files/spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

Copy link
Copy Markdown
Collaborator

@Kincekara Kincekara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

closes #1631

@Kincekara Kincekara merged commit 53a3219 into StaPH-B:master Apr 30, 2026
2 checks passed
@Kincekara
Copy link
Copy Markdown
Collaborator

Thank you for your PR!
You can check the image deployment status here: https://github.com/StaPH-B/docker-builds/actions/runs/25173180411
The images will be available on Dockerhub and Quay.io:
staphb/poppunk:2.7.8-x86_64_v3
staphb/poppunk:latest
quay.io/staphb/poppunk:2.7.8-x86_64_v3
quay.io/staphb/poppunk:latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants