Skip to content

Improve compatibility of PopPUNK v2.7.8#1670

Closed
HarryHung wants to merge 0 commit intoStaPH-B:masterfrom
HarryHung:master
Closed

Improve compatibility of PopPUNK v2.7.8#1670
HarryHung wants to merge 0 commit intoStaPH-B:masterfrom
HarryHung:master

Conversation

@HarryHung
Copy link
Copy Markdown
Contributor

  1. Force the conda solver to use x86-64-v3 instruction set to resolve compatibility issue mentioned in [Bug]: PopPUNK v2.7.8 - Illegal instruction #1631
  2. Update links in the README.md

Pull Request (PR) checklist:

  • Include a description of what is in this pull request in this message.
  • The dockerfile successfully builds to a test target for the user creating the PR. (i.e. docker build --tag samtools:1.15test --target test docker-builds/build-files/samtools/1.15 )
  • Directory structure as name of the tool in lower case with special characters removed with a subdirectory of the version number in build-files (i.e. docker-builds/build-files/spades/3.12.0/Dockerfile)
    • (optional) All test files are located in same directory as the Dockerfile (i.e. build-files/shigatyper/2.0.1/test.sh)
  • Create a simple container-specific README.md in the same directory as the Dockerfile (i.e. docker-builds/build-files/spades/3.12.0/README.md)
    • If this README is longer than 30 lines, there is an explanation as to why more detail was needed
  • Dockerfile includes the recommended LABELS
  • Main README.md has been updated to include the tool and/or version of the dockerfile(s) in this PR
  • Program_Licenses.md contains the tool(s) used in this PR and has been updated for any missing

@Kincekara
Copy link
Copy Markdown
Collaborator

Hi @HarryHung,
Thank you for your PR addressing this issue. We avoid overwriting deployed images, so we need a few minor changes in your PR:

  • Please create a folder at build-files/poppunk/2.7.8-x86_64_v3 and move your Dockerfile and README into it.
  • Add the new version 2.7.8-x86_64_v3 to the main README.

Let us know if you have any questions.

@HarryHung
Copy link
Copy Markdown
Contributor Author

Hi @Kincekara, I have replaced this PR with #1672 to address your requirements. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants