Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add Pull Request Template #99

Closed
officeneerajsaini opened this issue May 18, 2024 · 4 comments · Fixed by #116
Closed

Docs: Add Pull Request Template #99

officeneerajsaini opened this issue May 18, 2024 · 4 comments · Fixed by #116
Assignees
Labels

Comments

@officeneerajsaini
Copy link
Contributor

Describe the issue

Without a proper pull request (PR) template, contributors sometimes submit PRs without providing adequate descriptions of the changes they have made. This lack of information makes it challenging for reviewers to understand the purpose and scope of the changes, verify them effectively, and ensure that the code meets the project's standards. Consequently, reviewers often need to spend extra time reviewing the entire codebase, which is inefficient and time-consuming.

Steps To Reproduce

  1. A contributor raises a PR without using a PR template.
  2. The PR lacks a clear description of the changes made.
  3. Reviewers have to manually inspect all the code changes to understand their purpose.
  4. The review process becomes lengthy and cumbersome.

Expected Behavior

When a PR template is used:

  • Contributors provide a clear and concise description of the changes made.
  • The template helps outline what areas of the code were modified and why.
  • Reviewers can quickly understand the context of the changes.
  • The review process becomes more efficient and less time-consuming.

Screenshots

Screenshot from 2024-05-18 17-42-22

Device Information [optional]

  • OS: Ubuntu
  • Browser: Chrome
  • Version: 20.04.6 LTS

Additional Information

Implementing a PR template can significantly improve the efficiency of the code review process. A well-defined template should prompt contributors to provide:

  • A summary of the changes made.
  • The reasons for the changes.
  • Any relevant issue numbers or references.
  • Instructions for testing the changes.
  • Any additional notes or context that might help the reviewers.

By using a PR template, we can ensure that all necessary information is provided upfront, allowing reviewers to focus on the quality and correctness of the code rather than spending excessive time deciphering what changes have been made and why. This will not only save time for reviewers but also improve the overall quality of the codebase.

Copy link

Congratulations, @officeneerajsaini! 🎉 Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!

We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@SrijanShovit
Copy link
Owner

We already have a template, but would like you @officeneerajsaini to improve it.

@officeneerajsaini
Copy link
Contributor Author

@SrijanShovit add level tag too.

@SrijanShovit
Copy link
Owner

@SrijanShovit add level tag too.

Will add once you finish working. I do remember these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants