1.8.3

Author: ftzi

.husky/post-checkout

@@ -1,4 +1 @@
-#!/usr/bin/env sh
-. "$(dirname -- "$0")/_/husky.sh"
-
 bun pre-commit

.husky/post-merge

@@ -1,5 +1,9 @@
 # Changelog
 
+## 1.8.3
+
+- Fix issue with ESLint's Flat Config
+
 ## 1.7.3
 
 - Updated Biome to 1.7.3; added the following disables:

.husky/pre-commit

@@ -4,8 +4,8 @@
  * These are ESLint rules that have corresponding and recommended Biome rules.
  */
 module.exports = {
-  extends: ["./eslint-config-prettier.js"],
   rules: {
+    ...require("./eslint-config-prettier.js").rules,
     "constructor-super": "off",
     "default-case-last": "off",
     "default-param-last": "off",

CHANGELOG.md

@@ -1,14 +1,14 @@
 {
   "name": "eslint-config-biome",
-  "version": "1.7.3",
+  "version": "1.8.3",
   "description": "Disables ESLint rules that have a recommended and equivalent Biome rule",
   "main": "index.js",
   "scripts": {
     "format": "biome check --apply-unsafe . && eslint --fix . package.json",
     "format:check": "biome check . && eslint . package.json",
     "pre-commit": "bun format && bun typecheck && bun test && git add -A",
-    "prepare": "husky install",
-    "start": "bun run scripts/index.ts",
+    "prepare": "husky",
+    "start": "bun i && bun run scripts/index.ts",
     "test:watch": "bun test --watch",
     "tsw": "tsc --watch --noEmit",
     "typecheck": "tsc --noEmit",
@@ -33,13 +33,13 @@
   ],
   "repository": "SrBrahma/eslint-config-biome",
   "devDependencies": {
-    "@biomejs/biome": "^1.7.3",
-    "@sindresorhus/tsconfig": "^5.0.0",
-    "@types/bun": "^1.1.3",
-    "@types/jsdom": "^21.1.6",
+    "@biomejs/biome": "^1.8.3",
+    "@sindresorhus/tsconfig": "^5.1.1",
+    "@types/bun": "^1.1.8",
+    "@types/jsdom": "^21.1.7",
     "eslint-config-gev": "4.5.1",
-    "husky": "^9.0.11",
-    "jsdom": "^24.1.0",
-    "typescript": "^5.4.5"
+    "husky": "^9.1.5",
+    "jsdom": "^24.1.3",
+    "typescript": "^5.5.4"
   }
 }

index.js

@@ -8,12 +8,16 @@ import { spawnSync } from "bun"
 const rootPath = path.resolve(__dirname, "..")
 const indexPath = path.resolve(rootPath, "index.js")
 const prettierPath = path.resolve(rootPath, "eslint-config-prettier.js")
-const indexContent = fs.readFileSync(indexPath, "utf-8")
 const disabledRules = Object.keys(
   (require(indexPath) as { rules: Record<string, string> }).rules,
 )
 const prettierContent = fs.readFileSync(prettierPath, "utf-8")
 
+// @ts-expect-error
+import prettierJs from "../eslint-config-prettier.js"
+// @ts-expect-error
+import indexJs from "../eslint-config-prettier.js"
+
 test("index.js is a valid file and can be used by eslint", () => {
   // In the root there is a .eslintrc that uses the index.js in the extends.
   expect(
@@ -47,8 +51,13 @@ test("TS extensions should be added to index.js", () => {
 })
 
 test("eslint-config-prettier is used and is valid", () => {
-  expect(indexContent).toContain('extends: ["./eslint-config-prettier.js"],')
   expect(prettierContent).toContain('"react/jsx-indent": "off"')
+  expect((prettierJs as { rules: Record<string, unknown> }).rules).toContainKey(
+    "react/jsx-indent",
+  )
+  expect((indexJs as { rules: Record<string, unknown> }).rules).toContainKey(
+    "react/jsx-indent",
+  )
 })
 
 test("doesnt include clippy rules", () => {

package.json

@@ -5,7 +5,7 @@ import { getEquivalentRulesFromDocs } from "./fetchFromDocs"
 import { getEslintEquivalentRulesFromGithub } from "./fetchFromGithub.js"
 import { createPrettierFile } from "./prettier"
 import { getJsBaseRules, getTsExtensionsForRules } from "./tsExtensions"
-import { sortRules, writeFile } from "./utils"
+import { sortRules, writeMainFile } from "./utils"
 
 const main = async () => {
   const rules = [
@@ -22,7 +22,7 @@ const main = async () => {
 
   const rulesNoDuplicates = [...new Set(rulesWithTsExtends)]
 
-  writeFile(sortRules(rulesNoDuplicates))
+  writeMainFile(sortRules(rulesNoDuplicates))
   await createPrettierFile()
 
   console.log(`Generated ${filenames.index} & ${filenames.prettier}!`)

scripts/index.test.ts

@@ -31,7 +31,7 @@ export const sortRules = (rules: Array<string>) =>
     return a.localeCompare(b)
   })
 
-export const writeFile = (rules: Array<string>) => {
+export const writeMainFile = (rules: Array<string>) => {
   fs.writeFileSync(
     filenames.index,
     `/**
@@ -40,8 +40,8 @@ export const writeFile = (rules: Array<string>) => {
  * These are ESLint rules that have corresponding and recommended Biome rules.
  */
 module.exports = {
-  extends: ["./${filenames.prettier}"],
   rules: {
+    ...require("./eslint-config-prettier.js").rules,
 ${rules.map((rule) => `    "${rule}": "off",`).join("\n")}
   }
 }