Skip to content

Commit 448f1a2

Browse files
Change remaining instances of "fan curve" to "fan profile"
Configs aren't affected for compatibility purposes
1 parent 4953e62 commit 448f1a2

File tree

9 files changed

+24
-23
lines changed

9 files changed

+24
-23
lines changed

Docs/MSI EC Research.md

+5-5
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ above 100% do not appear to speed up the fan any further on the GF63 Thin 11SC
5959

6060
## `0x72..0x79`
6161

62-
Stores the fan curve for the CPU fan profile.
62+
Stores the fan profile for the CPU fan.
6363

6464
`0x79` appears to be tied to `0x70`, which doesn't appear to have its own
6565
temperature down threshold. This value is also set to `0x64` (100% fan speed)
@@ -104,7 +104,7 @@ Stores the current GPU fan speed target (from 0-100%).
104104

105105
## `0x8A..0x91`
106106

107-
Stores the fan curve for the GPU fan profile.
107+
Stores the fan profile for the GPU fan.
108108

109109
`0x91` appears to be tied to `0x88`, which doesn't appear to have its own
110110
temperature down threshold. This value is also set to `0x64` (100% fan speed)
@@ -163,7 +163,7 @@ Controls the performance level of the laptop:
163163
- `0xC2`: Low:
164164
- Limits CPU power draw to 10W while active (but not the dGPU power draw, funnily enough).
165165
- Modifys some fan settings. This is still being studied, but appears to completely mess up
166-
custom fan curves.
166+
custom fan profiles.
167167

168168
## `0xD3`
169169

@@ -173,8 +173,8 @@ Controls the keyboard backlight. The brightness level can be set using
173173

174174
## `0xD4`
175175

176-
Appears to change some fan control setting, must be written to `0x4D` for fan
177-
control curve to be applied correctly (Default: `0x0D`)
176+
Appears to change some fan control setting, must be written to `0x4D` for
177+
manually set fan profiles to be applied correctly (Default: `0x0D`)
178178

179179
## `0xD7`
180180

README.md

+4-3
Original file line numberDiff line numberDiff line change
@@ -43,9 +43,9 @@ A fast, lightweight MSI Center alternative and fan control utility for MSI lapto
4343

4444
## Features
4545

46-
- **Fan control:** Change the fan curves for your CPU and GPU fans, including
46+
- **Fan control:** Change the fan profiles for your CPU and GPU fans, including
4747
fan speeds, temperature thresholds, and Full Blast (a.k.a. Cooler Boost in
48-
MSI Center). This allows you to fix a curve that is not aggressive enough
48+
MSI Center). This allows you to fix a fan profile that isn't aggressive enough
4949
under full load, turn your fans off when your computer is idle, or just give
5050
them a boost during CPU-heavy tasks.
5151
- **Performance mode:** MSI laptops have their own performance mode setting
@@ -72,6 +72,7 @@ Currently, there are configs for the following laptops:
7272

7373
- MSI Alpha 17 C7VF (thanks @SethCodingInc)
7474
- MSI Bravo 15 B7ED (thanks @VisionCrizzal)
75+
- MSI Bravo 17 C7VE (thanks @advait404)
7576
- MSI Crosshair 17 B12UGZ (thanks @ios7jbpro)
7677
- MSI GF63 Thin 11SC
7778
- MSI Katana GF66 12UG (thanks @porkmanager)
@@ -80,7 +81,7 @@ Currently, there are configs for the following laptops:
8081

8182
There are also generic configs that should work with most MSI laptops, but with
8283
an incorrect default config. You can use the EC-to-config feature to get the
83-
proper fan curves for your laptop, then [create a pull request](https://github.com/Sparronator9999/YAMDCC/pulls)
84+
proper fan profiles for your laptop, then [create a pull request](https://github.com/Sparronator9999/YAMDCC/pulls)
8485
to get your laptop's config added to the project.
8586

8687
Other laptop brands are not officially supported. You can still try and

YAMDCC.Common/Configs/FanConf.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ public sealed class FanConf
9393
/// </summary>
9494
/// <remarks>
9595
/// If the base config is a template, this may be <see langword="null"/>,
96-
/// otherwise at least one fan curve (the "default" curve) must exist.
96+
/// otherwise at least one fan profile (the "default" profile) must exist.
9797
/// </remarks>
9898
[XmlArray]
9999
public List<FanCurveConf> FanCurveConfs { get; set; }

YAMDCC.Common/Configs/TempThreshold.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
namespace YAMDCC.Common.Configs;
2020

2121
/// <summary>
22-
/// Represents a fan speed/temperature threshold setting for a fan curve.
22+
/// Represents a fan speed/temperature threshold setting for a fan profile.
2323
/// </summary>
2424
public sealed class TempThreshold
2525
{

YAMDCC.Common/Configs/YAMDCC_Config.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -259,20 +259,20 @@ private bool IsValid()
259259
return false;
260260
}
261261

262-
// the selected fan curve shouldn't be higher than
263-
// the number of fan curves in the config.
262+
// the selected fan profile shouldn't be higher than
263+
// the number of fan profiles in the config.
264264
if (cfg.CurveSel >= FanConfs[i].FanCurveConfs.Count ||
265265
cfg.CurveSel < 0)
266266
{
267267
// if the fan profile selection is out of range,
268-
// silently set it to 0 (the first fan curve)
268+
// silently set it to 0 (the first fan profile)
269269
// which should always exist:
270270
cfg.CurveSel = 0;
271271
}
272272

273273
// make sure that:
274274
// - there is at least one each of up threshold, down threshold,
275-
// and fan curve registers
275+
// and fan profile registers
276276
// - there are the same amount of up threshold registers
277277
// as down threshold registers
278278
// - there is one more fan profile register than up/down threshold registers

YAMDCC.ConfigEditor/MainForm.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -756,7 +756,7 @@ private void ProfSelChanged(object sender, EventArgs e)
756756
bool enable = curveCfg.Name != "Default";
757757
for (int i = 0; i < numFanSpds.Length; i++)
758758
{
759-
// Fan curve
759+
// Fan profile
760760
TempThreshold t = curveCfg.TempThresholds[i];
761761
numFanSpds[i].Value = tbFanSpds[i].Value = t.FanSpeed;
762762
numFanSpds[i].Enabled = enable;

YAMDCC.ConfigEditor/Strings.resx

+2-2
Original file line numberDiff line numberDiff line change
@@ -304,13 +304,13 @@ Please re-run this program as Administrator
304304
You will need to reboot your computer to reset the fan profiles to their defaults.</value>
305305
</data>
306306
<data name="dlgECtoConfErr" xml:space="preserve">
307-
<value>An error occurred while fetching your laptop's default fan curves.
307+
<value>An error occurred while fetching your laptop's default fan profiles.
308308

309309
This is probably a bug; please report this to YAMDCC's issue tracker, including the log folder
310310
(located at {0}).</value>
311311
</data>
312312
<data name="dlgECtoConfSuccess" xml:space="preserve">
313-
<value>Your laptop's default fan curves have been saved to the currently applied config successfully.
313+
<value>Your laptop's default fan profiles have been saved to the currently applied config successfully.
314314

315315
Make sure to save your config (using the "Save config" button)!</value>
316316
</data>

YAMDCC.Service/FanControlService.cs

+4-4
Original file line numberDiff line numberDiff line change
@@ -119,13 +119,13 @@ protected override void OnStart(string[] args)
119119

120120
Log.Info(Strings.GetString("svcStarted"));
121121

122-
// Attempt to read default fan curve if it's pending:
122+
// Attempt to read default fan profile if it's pending:
123123
if (CommonConfig.GetECtoConfState() == ECtoConfState.PostReboot)
124124
{
125125
ECtoConf();
126126
}
127127

128-
// Apply the fan curve and charging threshold:
128+
// Apply the fan profiles and charging threshold:
129129
if (confLoaded)
130130
{
131131
ApplyConf();
@@ -183,7 +183,7 @@ protected override bool OnPowerEvent(PowerBroadcastStatus powerStatus)
183183
{
184184
// fan settings get reset on sleep/restart
185185
FullBlastEnabled = false;
186-
// Re-apply the fan curve after waking up from sleep:
186+
// Re-apply the fan profiles after waking up from sleep:
187187
Log.Info(Strings.GetString("svcWake"));
188188
ApplyConf();
189189
CooldownTimer.Start();
@@ -898,7 +898,7 @@ private bool ECtoConf()
898898
cfg.CurveSel++;
899899
}
900900

901-
// reset first fan curve config description
901+
// reset each fan's first fan profile descriptions
902902
curveCfg.Desc = Strings.GetString("DefaultDesc");
903903

904904
for (int j = 0; j < curveCfg.TempThresholds.Count; j++)

YAMDCC.Service/Strings.resx

+2-2
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ Args: {1}</value>
196196
<value>Writing custom EC register configs ({0}/{1})...</value>
197197
</data>
198198
<data name="svcWriteFanConfs" xml:space="preserve">
199-
<value>Writing fan curve config for `{0}` ({1}/{2})...</value>
199+
<value>Writing fan profile for `{0}` ({1}/{2})...</value>
200200
</data>
201201
<data name="svcWriteChgLim" xml:space="preserve">
202202
<value>Writing charge limit configuration...</value>
@@ -238,7 +238,7 @@ Please run 'YAMDCC.exe' instead.</value>
238238
<value>Failed to get computer manufacturer!</value>
239239
</data>
240240
<data name="svcWake" xml:space="preserve">
241-
<value>Resume from sleep detected, re-applying fan curve...</value>
241+
<value>Resume from sleep detected, re-applying fan profile...</value>
242242
</data>
243243
<data name="svcWriteFanMode" xml:space="preserve">
244244
<value>Writing fan mode setting...</value>

0 commit comments

Comments
 (0)