Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Top Addresses" bar plot is unlabeled #136

Open
ctwardy opened this issue Dec 12, 2018 · 1 comment
Open

"Top Addresses" bar plot is unlabeled #136

ctwardy opened this issue Dec 12, 2018 · 1 comment
Labels
enhancement good first issue Easy or quick fix expected

Comments

@ctwardy
Copy link
Contributor

ctwardy commented Dec 12, 2018

[Updated after reading sotera.github.io/newman/features].

In the "Top Addresses" screenshot below, [email protected] shows 79% in the donut plot and 0.988 in the bar plot.
screen shot 2018-12-12 at 9 26 51 am

I thought the 0.988 was a proportion -- which doesn't match the 79%. But the features doc says "Top Addresses uses a custom algorithm to determine important email addresses in the data set." So I guess this is "importance".

In that case, the fix is to label it, either in the tab bar (top right) or the graph area (bottom right? above the top bar?)

Adding a label is probably a good first issue.

I'm using version 4.0.0 running on our AWS merlin-stack, with the jeb bush dataset.

@ctwardy ctwardy added the bug label Dec 12, 2018
@ctwardy
Copy link
Contributor Author

ctwardy commented Dec 12, 2018

[Updated as above. Some changes shown, some just cleaned.]

The bar lengths seem okay, so just the numbers are off unclear. [Seems they are importances.]

The different plots show the following things:

  • The "Entities" barplot shows counts.
  • The "Topics" barplot shows percents. They match the donut plot %s.
  • "Top Addresses" appears to show proportions shows importance. Numbers do not match
  • " Domains" shows counts.
  • "Communities" shows counts.
  • "File Types" shows counts.
  • "Attachments" shows a time histogram. Different, but I guess okay.
    • Maybe redo the tab bar as "Attachments: [Timeline] [File Types]"

@ctwardy ctwardy changed the title Mismatched %s between bar & donut plots "Top Addresses" donut plot % does not match bar plot %. Dec 12, 2018
@ctwardy ctwardy changed the title "Top Addresses" donut plot % does not match bar plot %. "Top Addresses" bar plot is unlabeled Dec 12, 2018
@ctwardy ctwardy added enhancement good first issue Easy or quick fix expected and removed bug labels Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good first issue Easy or quick fix expected
Projects
None yet
Development

No branches or pull requests

1 participant