Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix S2629 FP: Constant fields in interpolated string #9247

Closed
Tim-Pohlmann opened this issue May 3, 2024 · 0 comments · Fixed by #9384
Closed

Fix S2629 FP: Constant fields in interpolated string #9247

Tim-Pohlmann opened this issue May 3, 2024 · 0 comments · Fixed by #9384
Assignees
@mary-georgiou-sonarsource
Labels
Area: C# C# rules related issues. Type: False Positive Rule IS triggered when it shouldn't be.
Projects
Best Kanban
Milestone
9.27

Comments

@Tim-Pohlmann
Copy link
Contributor

Tim-Pohlmann commented May 3, 2024 •
edited 

logger.Log(LogLevel.Warning, $"Constant: {FieldConstant}");  // Noncompliant FP

Originally reported by community.
@Tim-Pohlmann Tim-Pohlmann added Type: False Positive Rule IS triggered when it shouldn't be. Area: C# C# rules related issues. labels May 3, 2024
@Tim-Pohlmann Tim-Pohlmann mentioned this issue May 3, 2024
Merged
Tim-Pohlmann added a commit that referenced this issue May 6, 2024
@Tim-Pohlmann
S2629: Add Repro for #9247 (#9248)
cec9715
Merged
@github-actions github-actions bot added this to Review in progress in Best Kanban Jun 4, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource added this to the 9.27 milestone Jun 4, 2024
@github-actions github-actions bot moved this from Review in progress to Review approved in Best Kanban Jun 4, 2024
Best Kanban automation moved this from Review approved to Validate Peach Jun 4, 2024
@mary-georgiou-sonarsource mary-georgiou-sonarsource moved this from Validate Peach to Done in Best Kanban Jun 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mary-georgiou-sonarsource mary-georgiou-sonarsource

Labels
Area: C# C# rules related issues. Type: False Positive Rule IS triggered when it shouldn't be.
Projects
Best Kanban
  
Done
Milestone
9.27
Development

Successfully merging a pull request may close this issue.

Fix S2629 FP: Constant fields in interpolated string SonarSource/sonar-dotnet
3 participants
@Tim-Pohlmann @mary-georgiou-sonarsource @zsolt-kolbay-sonarsource