Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[devtools] login with invalid creds #19

Open
revolunet opened this issue Dec 26, 2022 · 1 comment
Open

[devtools] login with invalid creds #19

revolunet opened this issue Dec 26, 2022 · 1 comment
Labels
bug Something isn't working 📦 devtools question Further information is requested

Comments

@revolunet
Copy link
Member

Note sure if this is intended or not but in devtools, login with invalid creds does not return server errors

e2esdk-login

@revolunet revolunet added the question Further information is requested label Dec 26, 2022
@franky47
Copy link
Contributor

franky47 commented Dec 26, 2022

The concept of login here is a bit different to traditional client/server interactions.

There is no interaction with the server needed to login, it's a local key derivation procedure. It has the advantage of making the system work offline, but we could add a handshake with the server to verify if the derived identity is registered (it would also double up as verifying the server has the right information).

In your example, passing an invalid main key (wrong length) should result in an immediate error in the key derivation code, I'll have to take a look at that. Though in practice entering a main key directly is a temporary thing, later on it will be hidden under an authentication strategy (password, local device, WebAuthn etc..).

Now the actual server error you see is an unauthorized error, meaning there is no account associated with the locally derived identity. This indeed needs some UI feedback on the devtools.

@franky47 franky47 added bug Something isn't working 📦 devtools labels Dec 26, 2022
@franky47 franky47 mentioned this issue Jan 11, 2023
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 📦 devtools question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants