Fix text being rendered with z offset

Author: SmylerMC

smylib/fabric/src/main/java/net/smyler/smylib/gui/PatchedFont.java

@@ -0,0 +1,8 @@
+package net.smyler.smylib.gui;
+
+/**
+ * Exposes methods declared in {@link net.smyler.smylib.mixins.FontMixinNoShadowOffset}.
+ */
+public interface PatchedFont {
+    void smylib$setCancelShadowOffset(boolean cancelShadowOffset);
+}

smylib/fabric/src/main/java/net/smyler/smylib/gui/WrappedFont.java

@@ -65,7 +65,13 @@ public float draw(float x, float y, @NotNull String text, @NotNull Color color,
         gl.scale(this.scale, this.scale);
         x *= invScale;
         y *= invScale;
+
+        // Vanilla does a z-translation call to draw the shadow,
+        // We need to work around that (it is useless and messes z coordinates).
+        PatchedFont patchedFont = (PatchedFont) this.vanillaFont;
+        patchedFont.smylib$setCancelShadowOffset(true);
         float result = this.vanillaGraphics.drawString(this.vanillaFont, text, (int) x, (int) y, color.asInt());
+        patchedFont.smylib$setCancelShadowOffset(false);
         gl.scale(invScale, invScale);
         return result;
     }

smylib/fabric/src/main/java/net/smyler/smylib/mixins/FontMixinNoShadowOffset.java

@@ -0,0 +1,38 @@
+package net.smyler.smylib.mixins;
+
+import net.minecraft.client.gui.Font;
+import net.smyler.smylib.gui.PatchedFont;
+import org.joml.Matrix4f;
+import org.joml.Vector3fc;
+import org.spongepowered.asm.mixin.Mixin;
+import org.spongepowered.asm.mixin.Unique;
+import org.spongepowered.asm.mixin.injection.At;
+import org.spongepowered.asm.mixin.injection.Redirect;
+
+
+@Mixin(Font.class)
+public abstract class FontMixinNoShadowOffset implements PatchedFont {
+
+    @Unique
+    private boolean cancelShadowOffset = false;
+
+    @Redirect(
+            method = "drawInternal(Ljava/lang/String;FFIZLorg/joml/Matrix4f;Lnet/minecraft/client/renderer/MultiBufferSource;Lnet/minecraft/client/gui/Font$DisplayMode;IIZ)I",
+            at = @At(
+                    value = "INVOKE",
+                    target = "Lorg/joml/Matrix4f;translate(Lorg/joml/Vector3fc;)Lorg/joml/Matrix4f;",
+                    remap = false  // Method is from JOML, it isn't obfuscated
+            )
+    )
+    public Matrix4f applyShadowOffset(Matrix4f matrix, Vector3fc offset) {
+        if (!this.cancelShadowOffset) {
+            matrix.translate(offset);
+        }
+        return matrix;
+    }
+
+    public void smylib$setCancelShadowOffset(boolean cancelShadowOffset) {
+        this.cancelShadowOffset = cancelShadowOffset;
+    }
+
+}

smylib/fabric/src/main/resources/smylib.fabric.mixins.json

@@ -6,6 +6,7 @@
   "compatibilityLevel": "JAVA_21",
   "mixins": [],
   "client": [
+    "FontMixinNoShadowOffset",
     "UiGraphicsInjectorMixin"
   ],
   "server": [],