Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transform_cat() corrections to parallax when changing epochs. #116

Closed
attipaci opened this issue Jan 23, 2025 · 1 comment · Fixed by #113
Closed

transform_cat() corrections to parallax when changing epochs. #116

attipaci opened this issue Jan 23, 2025 · 1 comment · Fixed by #113
Labels
bug Something isn't working
Milestone
1.3.0

Comments

@attipaci
Copy link
Collaborator

attipaci commented Jan 23, 2025 •
edited
Loading

This is a legacy NOVAS C issue.

Lindengren & Dravins (2021) describe geometric corrections that should be applied when transforming proper motion and parallax measures from one epoch to another, due to the changign distance to the star. These corrections were not present in NOVAS C or in prior SuperNOVAS releases, but it makes sens to add them to be part of the existing transform_cat() function starting with the next feature release.
@attipaci attipaci added the enhancement New feature or request label Jan 23, 2025
@attipaci attipaci added this to the 1.3.0 milestone Jan 23, 2025
@attipaci attipaci linked a pull request Jan 23, 2025 that will close this issue
New functions for v1.3 #113
Merged
@attipaci attipaci mentioned this issue Jan 23, 2025
Merged
@attipaci attipaci pinned this issue Jan 23, 2025
@attipaci attipaci added wontfix This will not be worked on and removed enhancement New feature or request labels Jan 23, 2025
@attipaci
Copy link
Collaborator Author

attipaci commented Jan 23, 2025 •
edited
Loading

Actually, transform_cat() provided an equivalent approach already for the proper-motion, but it did not update the parallax with the recalculated value. Fixed by commit c5fca57

@attipaci attipaci unpinned this issue Jan 23, 2025
@attipaci attipaci removed a link to a pull request Jan 23, 2025
New functions for v1.3 #113
Merged
@attipaci attipaci pinned this issue Jan 23, 2025
@attipaci attipaci reopened this Jan 23, 2025
@attipaci attipaci linked a pull request Jan 23, 2025 that will close this issue
New functions for v1.3 #113
Merged
@attipaci attipaci added bug Something isn't working and removed wontfix This will not be worked on labels Jan 23, 2025
@attipaci attipaci changed the title Geometric corrections to proper motion and parallax when changing epochs. Geometric corrections to parallax when changing epochs. Jan 24, 2025
@attipaci attipaci changed the title Geometric corrections to parallax when changing epochs. transform_cat() corrections to parallax when changing epochs. Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
1.3.0
Development

Successfully merging a pull request may close this issue.

New functions for v1.3 Smithsonian/SuperNOVAS
1 participant
@attipaci