Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LSR vs SSB-based radial velocities for cat_entry #114

Closed
attipaci opened this issue Jan 21, 2025 · 0 comments · Fixed by #113
Closed

LSR vs SSB-based radial velocities for cat_entry #114

attipaci opened this issue Jan 21, 2025 · 0 comments · Fixed by #113
Labels
enhancement New feature or request
Milestone

Comments

@attipaci
Copy link
Collaborator

attipaci commented Jan 21, 2025

In NOVAS (and hence SuperNOVAS), the radial velocity in cat_entry is implicitly defined relative to the Solar-System Barycenter. However, stellar velocities are often defined vs the Local Standard of Rest (LSR). NOVAS C, and prior SuperNOVAS releases had no way to distinguish the two. To provide better support for LSR velocities, while maintaining backward compatibility to the maximum extent, we could:

  1. Document the API better to note that stellar radial velocities are defined relative to the SSB.
  2. Provide a means to specify stellar (Galactic) sources with LSR velocities, such as with novas_lsr_to_ssb_vel() to convert LSR veclocities to SSB-based radial velocities for make_cat_entry().
@attipaci attipaci added the bug Something isn't working label Jan 21, 2025
@attipaci attipaci added this to the 1.3.0 milestone Jan 21, 2025
@attipaci attipaci linked a pull request Jan 21, 2025 that will close this issue
@attipaci attipaci added enhancement New feature or request and removed bug Something isn't working labels Jan 23, 2025
@attipaci attipaci changed the title Inconsistent radial velocity measures returned in sky_pos LSR vs SSB-based radial velocities for cat_entry Jan 23, 2025
@attipaci attipaci pinned this issue Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant