Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KbdRc and SeatRc are leaked #1422

Open
ids1024 opened this issue May 7, 2024 · 3 comments · May be fixed by #1663
Open

KbdRc and SeatRc are leaked #1422

ids1024 opened this issue May 7, 2024 · 3 comments · May be fixed by #1663

Comments

@ids1024
Copy link
Member

ids1024 commented May 7, 2024

Looking at valgrind logs of anvil, it seems allocations that are part of KbdRc are never freed when exiting cleanly. It seems Drop is never called on KbdRc or SeatRc.

I think known_kbds needs to use Weak to avoid a reference cycle. I'm still unsure what is preventing SeatRc from being freed...
@ids1024
Copy link
Member Author

ids1024 commented May 7, 2024

Looks like SeatGlobalData and SeatUserData never get dropped.

@ids1024
Copy link
Member Author

ids1024 commented May 7, 2024

Or I guess SeatUserData is freed when a client exist before the compositor, but not when the compositor exits with a window open?

@PolyMeilex
Copy link
Member

This might have been fixed by: #1516

ids1024 added a commit to ids1024/smithay that referenced this issue Feb 25, 2025
@ids1024
Fix leaks of SeatRc and KbdRc, but using Weak in user data
38ed03a 
This fixes Smithay#1422.

This can be tested by adding `Drop` impls that print to those two types,
or using tools that detect leaks.
ids1024 added a commit to ids1024/smithay that referenced this issue Feb 25, 2025
@ids1024
Fix leaks of SeatRc and KbdRc, but using Weak in user data
abfd337 
This fixes Smithay#1422.

This can be tested by adding `Drop` impls that print to those two types,
or using tools that detect leaks.
@ids1024 ids1024 linked a pull request Feb 25, 2025 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix leaks of SeatRc and KbdRc, but using Weak in user data ids1024/smithay
2 participants
@ids1024 @PolyMeilex