-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
using sorl-thumbnail and easy-thumbnails side-by-side #401
Comments
@SmileyChris If we were to provide a PR for such a change, would you merge it? |
@SmileyChris @stefanfoulis Any updates on this? |
@stefanfoulis I am in favor for your renaming proposal. However, we must assure that there is a warning, if someone uses the old naming convention. |
I'm cool with this too.
I think rather than deprecating the common settings name for both packages
would be to just check for the installation of both packages and then fail,
requiring the unique settings names. If someone is only using the one
package, there's no real urgency for it to be renamed.
…On Mon, 13 Nov 2017 at 02:40 Jacob Rief ***@***.***> wrote:
@stefanfoulis <https://github.com/stefanfoulis> I am in favor for your
renaming proposal. However, we must assure that there is a warning, if
someone uses the old naming convention.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#401 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGtf27ZMKGywPDiGBviiUHBgIgiG7-3ks5s1vVLgaJpZM4HiztM>
.
|
Cool. Then it is relatively clear what to do. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
see jazzband/sorl-thumbnail#445
The text was updated successfully, but these errors were encountered: