-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Continuous integration of Slicer on centos (updated & rebased) #609
base: master
Are you sure you want to change the base?
WIP: Continuous integration of Slicer on centos (updated & rebased) #609
Conversation
After manually fetching your changes into I tweaked my small script to work for existing checkout. It is currently building. TEST_DIR=/tmp/test
mkdir -p $TEST_DIR
cd $TEST_DIR
dir=docker-opengl-centos
[[ ! -e $dir ]] && git clone git://github.com/thewtex/docker-opengl -b centos $dir
cd $dir
make
cd $TEST_DIR
dir=SlicerDocker
[[ ! -e $dir ]] && git clone git://github.com/MayeulChassagnard/SlicerDocker -b slicer-build-with-tests-rebased $dir
cd $dir
./build.sh
cd $TEST_DIR
dir=Slicer
[[ ! -e $dir ]] && git clone git://github.com/MayeulChassagnard/Slicer -b Continuous-Integration-on-centos-2016.10.20 $dir
cd $dir
./CMake/CircleCI/build.sh
./CMake/CircleCI/run.sh |
@jcfr @thewtex What is the status now? Can we merge this to be able to know finally if the all process works or not? |
@MayeulChassagnard The process status can be determined by the results on this PR. There are many people in the community collaboratively developing Slicer. It is important not to merge code with known build errors or test failures so that others are not distracted or confused by them. |
a2b45ed
to
db81a42
Compare
8a706f8
to
1196175
Compare
Wooooww! 🎆 🙌 🎉 It works finally! CircleCI details Going to update SlicerDocker to run all tests! |
bcd6e85
to
845cedb
Compare
What about running the test with |
It is already done: https://github.com/thewtex/SlicerDocker/blob/master/slicer-test/opengl/test.sh#L19 The fact is that it'll be displayed only when the container is stopped: https://github.com/MayeulChassagnard/Slicer/blob/Continuous-Integration-on-centos-2016.10.27-rebased/CMake/CircleCI/run_opengl.sh#L135-L148 |
@MayeulChassagnard some possible options:
|
845cedb
to
24eee72
Compare
e58f377
to
24bf254
Compare
145ec76
to
51999d4
Compare
py_AtlasTest seems not stable (http://slicer.cdash.org/index.php?project=Slicer4&date=2017-01-09##Experimental) Should we remove it from the test list? |
Run tests (which are built in the slicer/slicer-test docker image) with X_Window_System supported inside the slicer/slicer-test:opengl docker image based on thewtex/opengl:centos
…image * Remove mounted src (-v ...) from run-opengl.sh * Keep only useful files needed to run the tests from the src such as: - test.sh - CircleCI_Slicer_Docker.cmake - sumbit config CTestConfig.cmake (we copied directly what there is inside, into CircleCI_Slicer_Docker.cmake)
Only run.sh & run_opengl.sh are needed inside Slicer to be able to launch the automatic build & tests from circle.yml
FROM https://circleci.com/docs/docker-btrfs-error/ ``` When Docker creates a container, the container is created on Btrfs, the filesystem that we use to store all build containers, and removing a container is equivalent to removing a Btrfs subvolume. However, the Docker process doesn’t have permission to remove btrfs subvolumes, resulting in the error ``` BUG: --rm=false replaced by commenting docker rm cmd
…ests Because tests results were displayed only at the end, CircleCI was running into a timed out due to no output during more than 10minutes. Fixed by displaying a dot every minute.
This information should be provided by slicer-build docker image (The place where Slicer is built)
51999d4
to
7f73a93
Compare
Is it just a timeout issue?
…On Thu, Jan 12, 2017 at 12:41 PM, Mayeul Chassagnard < ***@***.***> wrote:
py_AtlasTest seems not stable (http://slicer.cdash.org/
index.php?project=Slicer4&date=2017-01-09##Experimental)
Should we remove it from the test list
<https://github.com/thewtex/SlicerDocker/blob/master/slicer-test/opengl/CircleCI_Slicer_Docker.cmake#L68>
?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<Slicer/Slicer#609 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAHsfWUMCJw91bxlmNvwCFl0gsB69-7Zks5rRmXMgaJpZM4KioiR>
.
|
@pieper Yes, and note that when I manually rebuild (by clicking the 'rebuild' button in CircleCI), the test becomes green (because it's executed in less than 10 minutes) |
Update of Slicer/Slicer#607