Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ctk cli2 #497

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add ctk cli2 #497

wants to merge 4 commits into from

Conversation

fbudin69500
Copy link
Member

@jcfr This is the new branch I created to address your comments from #493

ctk_cli [1] is a command line parsing python package that parses
arguments the same way SlicerExecutionModel does.
Using ctk_cli allows in Python scripts allows to have the same
user interface in Python or in C++.

[1] https://github.com/commontk/ctk-cli
Template argument name was modified in template declaration but not
when using it in the templated function.
ctk_cli allows to parse python scripts command lines
the same way they would be parsed with
SlicerExecutionModel. This commit adds an example to
show how to use this package.
Generating a new extension implementing a PythonCLI module by
calling the target SlicerGenerateExtensionTemplates.
@jcfr
Copy link
Member

jcfr commented May 19, 2016

Thanks for the PR.

I integrated the changes related to BUG: Template argument name was modified in template declaration …

I will post comment regarding the PythonCLI template

@@ -0,0 +1,36 @@
import itk
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://pypi.python.org/pypi/flake8-import-order

import logging
import sys

from ctk_cli import CLIArgumentParser

import itk

Useful resrouces: https://pypi.python.org/pypi/flake8-import-order and

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally, would it be possible to use SimpleITK, wrapped ITK is not yet enabled by default.

Thanks for your help

@jcfr jcfr added feature and removed feature labels Oct 12, 2016
@fedorov
Copy link
Member

fedorov commented Dec 7, 2016

@jcfr what is the status of this PR?

@jcfr
Copy link
Member

jcfr commented Dec 7, 2016

After updating the example so that it does not fail when wrapped itk is not available, it should be good.

@fedorov
Copy link
Member

fedorov commented Dec 7, 2016

Thanks JC!

@mehrtash perhaps it makes sense to build this branch and use it to wrap the deep learning models, as we discussed today? This way you can get started, and at the same time provide feedback to this PR. @jcfr perhaps if you are interested, we could discuss this project at a project week planning call? I will be traveling next Tue, but perhaps we could do it after that. Or should we arrange a separate meeting?

@jcfr
Copy link
Member

jcfr commented Aug 3, 2017

This branch will be integrated as soon as we complete the SlicerITK extension.

Cc: @fbudin69500 @thewtex

@jcfr
Copy link
Member

jcfr commented May 9, 2018

Update PyCLIModule4Test.py introduced in Slicer/Slicer#894 to use ctk-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

3 participants