-
Notifications
You must be signed in to change notification settings - Fork 458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ctk cli2 #497
base: master
Are you sure you want to change the base?
Add ctk cli2 #497
Conversation
ctk_cli [1] is a command line parsing python package that parses arguments the same way SlicerExecutionModel does. Using ctk_cli allows in Python scripts allows to have the same user interface in Python or in C++. [1] https://github.com/commontk/ctk-cli
Template argument name was modified in template declaration but not when using it in the templated function.
ctk_cli allows to parse python scripts command lines the same way they would be parsed with SlicerExecutionModel. This commit adds an example to show how to use this package.
Generating a new extension implementing a PythonCLI module by calling the target SlicerGenerateExtensionTemplates.
Thanks for the PR. I integrated the changes related to I will post comment regarding the PythonCLI template |
@@ -0,0 +1,36 @@ | |||
import itk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://pypi.python.org/pypi/flake8-import-order
import logging
import sys
from ctk_cli import CLIArgumentParser
import itk
Useful resrouces: https://pypi.python.org/pypi/flake8-import-order and
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additionally, would it be possible to use SimpleITK
, wrapped ITK is not yet enabled by default.
Thanks for your help
@jcfr what is the status of this PR? |
After updating the example so that it does not fail when wrapped itk is not available, it should be good. |
Thanks JC! @mehrtash perhaps it makes sense to build this branch and use it to wrap the deep learning models, as we discussed today? This way you can get started, and at the same time provide feedback to this PR. @jcfr perhaps if you are interested, we could discuss this project at a project week planning call? I will be traveling next Tue, but perhaps we could do it after that. Or should we arrange a separate meeting? |
This branch will be integrated as soon as we complete the SlicerITK extension. Cc: @fbudin69500 @thewtex |
Update |
@jcfr This is the new branch I created to address your comments from #493