Skip to content

Commit 439ea11

Browse files
committed
NewFrontend and NewBackend cannot fail
1 parent 2bc8f2e commit 439ea11

File tree

4 files changed

+6
-12
lines changed

4 files changed

+6
-12
lines changed

backend.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,8 @@ type Backend struct {
3333
}
3434

3535
// NewBackend creates a new Backend.
36-
func NewBackend(cr ChunkReader, w io.Writer) (*Backend, error) {
37-
return &Backend{cr: cr, w: w}, nil
36+
func NewBackend(cr ChunkReader, w io.Writer) *Backend {
37+
return &Backend{cr: cr, w: w}
3838
}
3939

4040
// Send sends a message to the frontend.

backend_test.go

+1-4
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,7 @@ func TestBackendReceiveInterrupted(t *testing.T) {
1212
server := &interruptReader{}
1313
server.push([]byte{'Q', 0, 0, 0, 6})
1414

15-
backend, err := pgproto3.NewBackend(pgproto3.NewChunkReader(server), nil)
16-
if err != nil {
17-
t.Fatal(err)
18-
}
15+
backend := pgproto3.NewBackend(pgproto3.NewChunkReader(server), nil)
1916

2017
msg, err := backend.Receive()
2118
if err == nil {

frontend.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,8 @@ type Frontend struct {
4242
}
4343

4444
// NewFrontend creates a new Frontend.
45-
func NewFrontend(cr ChunkReader, w io.Writer) (*Frontend, error) {
46-
return &Frontend{cr: cr, w: w}, nil
45+
func NewFrontend(cr ChunkReader, w io.Writer) *Frontend {
46+
return &Frontend{cr: cr, w: w}
4747
}
4848

4949
// Send sends a message to the backend.

frontend_test.go

+1-4
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,7 @@ func TestFrontendReceiveInterrupted(t *testing.T) {
3636
server := &interruptReader{}
3737
server.push([]byte{'Z', 0, 0, 0, 5})
3838

39-
frontend, err := pgproto3.NewFrontend(pgproto3.NewChunkReader(server), nil)
40-
if err != nil {
41-
t.Fatal(err)
42-
}
39+
frontend := pgproto3.NewFrontend(pgproto3.NewChunkReader(server), nil)
4340

4441
msg, err := frontend.Receive()
4542
if err == nil {

0 commit comments

Comments
 (0)