-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dynamic choice of browser context #107
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
P2
Stale
Comments
This issue is stale because it has been open for 30 days with no activity. |
This issue is stale because it has been open for 30 days with no activity. |
This issue was closed because it has been inactive for 14 days since being marked as stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
good first issue
Good for newcomers
help wanted
Extra attention is needed
P2
Stale
Although
chromium-headless
andchromium-heaful
are registered into BrowserContextFactory,we can only choose one for all tasks(workflows) because we create the type by reading the config in env.
skyvern/skyvern/webeye/browser_factory.py
Line 86 in d273510
Is it necessary to offer a dynamic option? maybe at the task(workflow) level? Like task(workflow) A could choose headless and task(workflow) B could choose headful?
Sure, the BROWSER_TYPE in the env config could be the default choice if not browser type is specified by the task(workflow).
The text was updated successfully, but these errors were encountered: