Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle "merge conflicts" more gracefully when saving sketches #106

Open
kyldvs opened this issue Aug 19, 2018 · 2 comments
Open

Handle "merge conflicts" more gracefully when saving sketches #106

kyldvs opened this issue Aug 19, 2018 · 2 comments

Comments

@kyldvs
Copy link

kyldvs commented Aug 19, 2018

Right now if I have the same sketch open in two tabs then do:

  1. (tab 1): Write "foo", then save
  2. (tab 2): Write "bar", then save
  3. (refresh either tab): Observe that only "bar" appears, and "foo" has been lost

There is no confirmation that "bar" is overriding "foo" on the second save. If my initial state of the sketch when I loaded the page is not the same as the current state of the sketch on the server when saving my changes a warning should come up asking me to confirm that I want to save.

@thangngoc89
Copy link
Member

I'll look into this. In the mean time, did you lost any content? I can recover it for you

@kyldvs
Copy link
Author

kyldvs commented Aug 19, 2018

Nope no content loss luckily :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants