Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid ViewsMetaData.json location? #144

Open
trendoid opened this issue Jan 11, 2024 · 2 comments
Open

Valid ViewsMetaData.json location? #144

trendoid opened this issue Jan 11, 2024 · 2 comments

Comments

@trendoid
Copy link

It looks like from the extended-content-list sample that the field mapping occurs in `Views/Shared/Components/SitefinityContentList/ViewsMetaData.json but there is also a ViewsMetaData.json file in the resource-package-minimal sample.

The only location that seems to work is in the Views/Shared/Components/SitefinityContentList/ViewsMetaData.json file.

Changing ResourcePackages/Minimal/Views/Shared/Components/SitefinityContentList/ViewsMetaData.json doesn't do anything.

Is this as intended? Can the useless file be removed? Or is this a bug? Can Resource Packages also have custom field mapping?

@Gebov
Copy link
Collaborator

Gebov commented Jan 12, 2024

Hello,

IMO the ViewsMetadata.json file should work per package since the views are specific to that package. The primary location (Views/Shared/Components/SitefinityContentList/ViewsMetaData.json) currently is used to override the default package we ship(Bootstrap), but it should be secondary if there is ViewsMetadata.json file for that specific package. We will log it as a bug

@trendoid
Copy link
Author

@Gebov Thanks. The team here and our service delivery partner agree with you on that. Thanks for submitting it as a bug.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants