Warnings during model binding

[jballe]

This line is causing a lot of console output and warnings when using the StarterKit.
I agree that it seems unexpected but should we give a warning? Or maybe it should be something that can be enabled/disabled?

https://github.com/Sitecore/ASP.NET-Core-SDK/blob/44c614011a9344e36624272b3f067017903eae3e/src/Sitecore.AspNetCore.SDK.RenderingEngine/Binding/SitecoreLayoutModelBinder.cs#L55..L60

In the NextJs SDK there are no warnings (and no strong types).

In the StarterKit there are several components that can use either a page/route field or a specific data source aka component field. That has been solved by using multiple fields and hereby the warning is triggered.

https://github.com/Sitecore/xmcloud-starter-dotnet/blob/main/headapps/aspnet-core-starter/Models/PageContent.cs

I would at least suggest that the out-of-the box configuration should not give a lot of warnings.

It might also be that it would be meaningfull with a binding that solves this fallback scenario (use component field if a data source value but fallback to route field) instead of building the logic in the head application over and over.

[robearlam]

Agree, this isn't ideal, but I think the log message is still helpful when building.

What would you think about us changing this to be a Debug message instead of a warning? That way developers could see the message to help them when needed, but it wont end up polluting prod logs?

[jballe]

Agree, it is much better to have it as a Debug message so developers have a chance to enable and investigate if binding result is not as expected but the default behavior is not "polluted" with those (expected) log warnings.

I still think it would be simpler and more clean to have a dedicated binder/attribute to indicate that the value should be from either datasource or page - and hereby remove a lot of code and complexity in the head application. But that could be a PR for the future 😆

Let's change to a Debug message 👍