Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Istanbul is misspelled in json-summary filename #216

Open
jsoref opened this issue Sep 14, 2023 · 0 comments
Open

Istanbul is misspelled in json-summary filename #216

jsoref opened this issue Sep 14, 2023 · 0 comments

Comments

@jsoref
Copy link

jsoref commented Sep 14, 2023

'json-summary': 'tmp/remapInstanbul.coverage-summary.json',

The line should really say remapIstanbul.coverage-summary.json...

This spelling was copied into codecov-bash in codecov/codecov-bash@e87e79f and eventually migrated to codecov_cli in:
https://github.com/codecov/codecov-cli/blob/c74b971dccf6ade219bce1904f1845d0213f48d2/codecov_cli/services/upload/coverage_file_finder.py#L125
which is then copied into some projects, e.g. https://grep.app/search?q=-name%20%27remapInstanbul, it seems to be a relatively small number of projects in GitHub: https://github.com/search?q=%2F-name%20%27remapInstanbul%2F&type=code

I'd be willing to offer a PR to fix this if the project would be open to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant