Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid resolving of relatively specified source files #129

Open
kripod opened this issue Jan 13, 2017 · 0 comments
Open

Invalid resolving of relatively specified source files #129

kripod opened this issue Jan 13, 2017 · 0 comments

Comments

@kripod
Copy link

kripod commented Jan 13, 2017

This is a specific issue which came to my attention while working on material-components-react.

As of commit 5d547fb879058025e0e704868f5560ce7748b64e, remap-istanbul works fine for linking compiled code to sources, but paths for the source files are invalid in coverage reports. I tried to fix this issue by PR #128 - it worked for MDC-React, but failled the CI tests of remap-istanbul.

material-components-react/coverage/coverage-final.json starts like:

{
"D:\\Development\\Projects\\material-components-react\\packages\\button\\dist\\index.jsx":{"path":"D:\\Development\\Projects\\material-components-react\\packages\\button\\dist\\index.jsx"

Instead of the desired output below:

{
"D:\\Development\\Projects\\material-components-react\\packages\\button\\src\\index.jsx":{"path":"D:\\Development\\Projects\\material-components-react\\packages\\button\\src\\index.jsx"

(The difference is between src and dist)

In order to reproduce the issue, please download MDC-React at the commit given above, and then execute the following commands:

npm i
npm run build
npm run coverage
@dylans dylans added this to the 0.9.0 milestone Jan 15, 2017
@dylans dylans modified the milestones: 0.9.0, 0.10.0 Feb 22, 2017
@dylans dylans removed this from the 0.10.0 milestone Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants