Should the IAuthenticationProviderCallback methods return a Negotiator?

[PureKrome]

@phillip-haydon bud - now that you've added in a ViewRenderer and Negotiator into the core Nancy with commit dabe211.... , should I be using the Negotiator for the return type instead of a ViewRenderer?

eg.

Negotiator Process(NancyModule nancyModule, AuthenticateCallbackResult result);

The 2x methods in this class can return various things. Generally -> a View to display some html or a Redirect (eg. 301 or 302).

Because it can return a redirect, i'm thinking that i need it to return a Negotiator, right?

[phillip-haydon]

The problem was that you couldn't access view from INancyModule, so I added view to the interface so your Process can return INancyModule then you can call view from the module directly along with the other extension methods which are implemented against the interface.

[PureKrome]

The problem was that you couldn't access view from INancyModule

yep - that's what I was trying to do and asked for that added.

so I added view to the interface

Yep, so I can now do what I've been trying to do :) sweet!

so your Process can return INancyModule

er.. return an INancyModule ???

this is the bit i'm confused over, now :(

i want to return a response result (ie. a view or a redirect). why would I return an INancyModule... when that is passed in?

[phillip-haydon]

All the extensions exist on the interface.

Now you can do:

module.Response.AsRedirect(...)

In theory.

Pull the CI build to test with.

[PureKrome]

Yep - i get that .. but why would i want to RETURN the module .. instead of calling the extension inside my Process(..) method and returning an IResponseFormatter or something?

basically - now that you've added in the the two properties to the interface .. what would you recommend is the strong type I should return?

remember - the developer might want to goto

1. a view (Hi! thanks for signing up).
2. another existing route (eg. redirect to homepage)
3. a wizard to ask for more info (eg. email addy cause twitter are f'wits and don't provide it - eg. redirect).

[phillip-haydon]

You're not returning the module, I don't understand WTF you're asking...

When you return module.View[...] you're returning the view, if you return module.Response.AsRedirect(...) you're returning the type returned by AsRedirect...

[PureKrome]

yep - agreed.

but u said this (which confused me)

so your Process can return INancyModule

which is not returning a view / as redirect.

So - that's been cleared up...

so what is the strong type to return? what is the base type of all of these? I thought I caould return an IReponseFormatter .. but a view isn't that, right?

what about a Negotiator? is that the new fancy way now which I should be returning?

[phillip-haydon]

Blah, man I never read what I write.

Process(NancyModule nancyModule, ....

I mean it can accept INancyModule as the argument now, rather than the concrete type.

[PureKrome]

HA 😄

so what should it return out of that method, now?

[phillip-haydon]

dynamic

Unless we're making it async in which case I need to look at Nancy impl.

Nancy uses dynamic to evaluate the type and decide how to handle it, i.e if you return 404 it will handle it as a status code. etc.

[PureKrome]

Urgh.. i was sooooooo afraid you were going to say dynamic because I always try and avoid that :(

I originally had that .. but was trying to avoid it.

But - you're my nancy teacher so I'll change it to dynamic then. Deal?

[phillip-haydon]

Yes.