Blood Cult DLC 1: Make It an Actually Playable Game (Mode)

[Remuchi]

Description

You don't actually have to pay for it, y'know?

TODO

• Fix bugs from discord thread.

---

Media

---

Changelog

🆑

• add: In-game guide book to kickstart your sinister activities.
• add: Constructs now have abilities.
• add: Rending rune and apocalypse rune now should only be placed in the specific spots on maps. Needs to be mapped.
• add: Veil Shifter now displays how much charges it has when examining.
• add: Cult runes now have descriptions. Also stating how much invokers required for each rune.
• add: Blood rites can now be dropped&deleted.
• add: Blood rites now suck... blood in 0.5 tiles radius.
• remove: Non-cultists can no longer examine runes.
• fix: Fixed Cult Objective Target selection. You can (and should) sacrifice your own people now.
• fix: Non cultists can no longer use veil shifter.
• fix: Teleport spell is no more a cheap rip-off and now actually teleports.
• fix: Timed Factories can't no more produce infinite number of entities.
• fix: Offering rune should now properly convert someone.
• fix: Sacrificing body with mind now properly transfers their mind to soul shard.
• fix: Shadow Shackles now cuffs the target instead of the caster (lmao).

[github-actions]

RSI Diff Bot; head commit dfe8fc9 merging into 33f80d6
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Objects/Weapons/Guns/Projectiles/projectiles2.rsi

State	Old	New	Status
gauntlet_echo			Added

Resources/Textures/WhiteDream/BloodCult/actions.rsi

State	Old	New	Status
gauntlet_echo			Added

Edit: diff updated after dfe8fc9

[BlueHNT]

Q1: Does offering rune only turn people into gems? Can you not convert?
Q2: Is the offering rune supposed to be the conversion one even?

N1: Shackles just straight up don't work. I hope this fixes them.
N2: Spear doesn't get recalled if stuck in wall, can be picked up by others and thrown back, ow.

[angelofallars]

Bugs reported from the last Deepstation round (some of these might have been fixed already):

• Conversion not working, and only turning people into soul shards works
• Cult constructs and soul shards don't have languages set up for them, so they speak only speak Universal and can't understand Eldritch

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[rbertoche]

This is starting to grow conflicts. I am going to make a merge with the conflict and if necessary open a new PR to merge this as is.

We've been running this on Pirata for a while now and although we haven't been able to test bloodcult as a gamemode, at round start yet, due to other unrelated issues and more recently not enough population, we have noticed no issue which would justify not merging this.

About the issue where people were just being transformed in soul shards: After talking with author she explained that ghosted or disconnected people, or people with mindshield are not supposed to be convertible while they are in such status. After this explanation I am yet to see behavior which I think is actually a bug.

I wanted to make more contributions to bloodcult but haven't been able to but I can help with getting this merged before it gets stale.

Another thing which is confusing about the comments here is it's not clear if they're just comments about bloodcult content in general or about a server running this early merged.

So TLDR; I recommend merging this as it does not break the game, has important bugfixes and is prone to getting stale.

[rbertoche]

There. I will now test if the merge did not introduce any new weirdness.

[rbertoche]

If you prefer I can PR it directly here instead.

[rbertoche]

Tests are ok. Converting still works after the merge, which was expected.

Throwing cultist items work as they should, I.E: Cultists can throw after new throwing changes, while non-Cultists get stunned when they try.

As a side note, converting dionas is not possible which seems intended. I'm not sure what's the species white/blacklist.

[VMSolidus]

Oh wait that's a weird but legitimate test fail. Huhh?

[Erisfiregamer1]

Heisentest?

[Remuchi]

I hate obscure test fails

[whateverusername0]

all maints worldwide preparing to copy cult into their own base

[Remuchi]

I swear to god each and every time I look into build fail it gives me new errors. Can't fix until tomorrow sadly so if anyone from maints can fix it for me I'll appreciate it

[VMSolidus]

I swear to god each and every time I look into build fail it gives me new errors. Can't fix until tomorrow sadly so if anyone from maints can fix it for me I'll appreciate it

Replace ComponentInit or ComponentStartup with MapInitEvent.

[Remuchi]

Replace ComponentInit or ComponentStartup with MapInitEvent.

I simply need to specify these thing properly in the Yaml but I have no time until tomorrow