Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken Weather's Audio Streaming #1285

Closed
DocNITE opened this issue Nov 26, 2024 · 1 comment · Fixed by #1501
Closed

Broken Weather's Audio Streaming #1285

DocNITE opened this issue Nov 26, 2024 · 1 comment · Fixed by #1501
Labels
Type: Bug [Un]intentional issue with something

Comments

@DocNITE
Copy link
Contributor

DocNITE commented Nov 26, 2024 •
edited
Loading

Description

For some reason WeatherSystem create too many audio streams and spam with it, until OpenAL will Out Of Memory

Error message:

[ERRO] clyde.oal: Failed to generate source. Too many simultaneous audio streams?    at System.Environment.get_StackTrace()
   at Robust.Client.Audio.AudioManager.CreateAudioSource(AudioStream stream) in /home/docnite/Desktop/C#/EE-PRs/RobustToolbox/Robust.Client/Audio/AudioManager.Public.cs:line 290
   at Robust.Client.Audio.AudioSystem.LoadStream[T](Entity`1 entity, T stream) in /home/docnite/Desktop/C#/EE-PRs/RobustToolbox/Robust.Client/Audio/AudioSystem.cs:line 623
   at Robust.Client.Audio.AudioSystem.CreateAndStartPlayingStream(Nullable`1 audioParams, AudioStream stream) in /home/docnite/Desktop/C#/EE-PRs/RobustToolbox/Robust.Client/Audio/AudioSystem.cs:line 665
   at Robust.Client.Audio.AudioSystem.PlayGlobal(String filename, Nullable`1 audioParams, Boolean recordReplay) in /home/docnite/Desktop/C#/EE-PRs/RobustToolbox/Robust.Client/Audio/AudioSystem.cs:line 494
   at Content.Client.Weather.WeatherSystem.Run(EntityUid uid, WeatherData weather, WeatherPrototype weatherProto, Single frameTime) in /home/docnite/Desktop/C#/EE-PRs/Content.Client/Weather/WeatherSystem.cs:line 30
   at Content.Shared.Weather.SharedWeatherSystem.Update(Single frameTime) in /home/docnite/Desktop/C#/EE-PRs/Content.Shared/Weather/SharedWeatherSystem.cs:line 147
   at Robust.Shared.GameObjects.EntitySystemManager.TickUpdate(Single frameTime, Boolean noPredictions) in /home/docnite/Desktop/C#/EE-PRs/RobustToolbox/Robust.Shared/GameObjects/EntitySystemManager.cs:line 306
   at Robust.Shared.GameObjects.EntityManager.TickUpdate(Single frameTime, Boolean noPredictions, Histogram histogram) in /home/docnite/Desktop/C#/EE-PRs/RobustToolbox/Robust.Shared/GameObjects/EntityManager.cs:line 273
   at Robust.Client.GameObjects.ClientEntityManager.TickUpdate(Single frameTime, Boolean noPredictions, Histogram histogram) in /home/docnite/Desktop/C#/EE-PRs/RobustToolbox/Robust.Client/GameObjects/ClientEntityManager.cs:line 194
   at Robust.Client.GameStates.ClientGameStateManager.ApplyGameState() in /home/docnite/Desktop/C#/EE-PRs/RobustToolbox/Robust.Client/GameStates/ClientGameStateManager.cs:line 284
   at Robust.Client.GameController.Tick(FrameEventArgs frameEventArgs) in /home/docnite/Desktop/C#/EE-PRs/RobustToolbox/Robust.Client/GameController/GameController.cs:line 552
   at Robust.Shared.Timing.GameLoop.Run() in /home/docnite/Desktop/C#/EE-PRs/RobustToolbox/Robust.Shared/Timing/GameLoop.cs:line 240
   at Robust.Client.GameController.ContinueStartupAndLoop(DisplayMode mode) in /home/docnite/Desktop/C#/EE-PRs/RobustToolbox/Robust.Client/GameController/GameController.Standalone.cs:line 162
   at Robust.Client.GameController.GameThreadMain(DisplayMode mode) in /home/docnite/Desktop/C#/EE-PRs/RobustToolbox/Robust.Client/GameController/GameController.Standalone.cs:line 147
   at Robust.Client.GameController.<>c__DisplayClass105_0.<Run>b__0() in /home/docnite/Desktop/C#/EE-PRs/RobustToolbox/Robust.Client/GameController/GameController.Standalone.cs:line 106m.Environment.get_StackTrace()

Reproduction

  1. Open game
  2. Type weather (map_id) (weather_proto)
  3. See errors spaming

Media

2024-11-27.01-55-19.1.mp4

(sorry for bad quality, i have some issues with recording it in 10 MB size)
@DocNITE DocNITE added the Type: Bug [Un]intentional issue with something label Nov 26, 2024
@DocNITE
Copy link
Contributor Author

DocNITE commented Jan 11, 2025

bump

@VMSolidus VMSolidus mentioned this issue Jan 11, 2025
Merged
VMSolidus added a commit that referenced this issue Jan 11, 2025
@VMSolidus
Fixes Weather Soundspam(And Crash) (#1501)
28415f1 
# Description

Pretty simple fix, just tell the weather system "If there's already a
weather sound playing, stop.". I have infact tested this, and verified
that this fix does work.

Fixes #1285

# Changelog

:cl:
- fix: Fixed a crash caused by Weather System creating millions of
sounds.
Spatison pushed a commit to Spatison/wwdpublic that referenced this issue Jan 15, 2025
@VMSolidus @Spatison
Fixes Weather Soundspam(And Crash) (#1501)
2848060 
# Description

Pretty simple fix, just tell the weather system "If there's already a
weather sound playing, stop.". I have infact tested this, and verified
that this fix does work.

Fixes Simple-Station/Einstein-Engines#1285

# Changelog

:cl:
- fix: Fixed a crash caused by Weather System creating millions of
sounds.

(cherry picked from commit 28415f18a1cb2549e9faa29c1ce66889dc0ef323)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug [Un]intentional issue with something
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes Weather Soundspam(And Crash) VMSolidus/Einstein-Engines
1 participant
@DocNITE