Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to specify the apple account and password in the web UI. #249

Open
jpdasma opened this issue Sep 18, 2022 · 2 comments
Open

Option to specify the apple account and password in the web UI. #249

jpdasma opened this issue Sep 18, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@jpdasma
Copy link

jpdasma commented Sep 18, 2022

When opting to use a developer account, it appears that we have to specify both the email and password in a text file:

data
|____profiles
| |____my_profile                # Or what you named your profile
| | |____cert.p12                # the signing certificate archive
| | |____cert_pass.txt           # the signing certificate archive's password
| | |____name.txt                # a name to show in the web interface
| | |____account_name.txt        # the developer account's name (email)
| | |____account_pass.txt        # the developer account's password
| |____my_other_profile
| | |____...

It's not really a good practice to store these in plaintext, even if we are running SignTools in a private server.

I suggest a feature to have an option to leave these empty and prompt the user for the email and password in the web UI.

@iitazz
Copy link

iitazz commented Sep 18, 2022

I agree, this would be a nice thing to be implemented!

@ViRb3 ViRb3 added the enhancement New feature or request label Sep 18, 2022
@ViRb3
Copy link
Member

ViRb3 commented Sep 18, 2022

Due to the nature of signing, even if you had a prompt for the credentials, they would still have to reach the builder in plaintext at some point, so you should always consider them compromised. This is party mitigated by 2FA, but yes, I agree that it is not "safe". Sadly, I don't think there's a "fully safe" solution for your credentials, so I highly recommend to use a separate account just for development. I don't think that the benefits of having a prompt are worth it (in my opinion, at least), so I will likely not implement this feature myself, but I am happy to take it as a PR from somebody else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants