[FEATURE] show a flash error, when sic_address gets updated and domain properties have already been saved. In this case the generate process has to be run again.

Adnan Zelkanovic · Adnan Zelkanovic · commit aa5f940d9ad1 · 2020-03-05T11:39:42.000+01:00
diff --git a/Classes/Controller/AbstractController.php b/Classes/Controller/AbstractController.php
@@ -1,9 +1,12 @@
 <?php
 namespace SICOR\SicAddress\Controller;
 
-class AbstractController extends \TYPO3\CMS\Extbase\Mvc\Controller\ActionController {
+use TYPO3\CMS\Core\Messaging\AbstractMessage;
+use TYPO3\CMS\Extbase\Mvc\View\ViewInterface;
 use TYPO3\CMS\Extbase\Utility\LocalizationUtility;
 
+class AbstractController extends \TYPO3\CMS\Extbase\Mvc\Controller\ActionController
+{
 
     /**
      * Returns translation for given key (and extension)
@@ -16,6 +19,24 @@ protected function translate($key, $extension = 'sic_address') {
         return LocalizationUtility::translate($key, $extension );
     }
 
+    /**
+     * @param ViewInterface $view
+     */
+    public function initializeView(ViewInterface $view)
+    {
+        parent::initializeView($view); // TODO: Change the autogenerated stub
+
+        if(! in_array($this->request->getControllerActionName(), array('create', 'update'))) {
+
+            $updateOrFirstInstall = \file_exists(PATH_typo3conf . 'ext/sic_address/PLEASE_GENERATE');
+            if($updateOrFirstInstall && $this->domainPropertyRepository && $this->domainPropertyRepository->countAll()) {
+                $this->addFlashMessage(
+                    $this->translate('label_update_message'),
+                    $this->translate('label_update_title'),
+                    AbstractMessage::ERROR
+                );
+            }
+        }
     }
 
 }
diff --git a/Classes/Controller/ModuleController.php b/Classes/Controller/ModuleController.php
@@ -285,6 +285,8 @@ public function createAction()
 
         $this->updateExtension();
         $this->view->assign("errorMessages", $errorMessages);
+
+        if(empty($errorMessages)) @unlink(PATH_typo3conf . 'ext/sic_address/PLEASE_GENERATE');
     }
 
 
diff --git a/PLEASE_GENERATE b/PLEASE_GENERATE
diff --git a/Resources/Private/Language/de.locallang.xlf b/Resources/Private/Language/de.locallang.xlf
@@ -3,6 +3,12 @@
 	<file datatype="plaintext" original="messages" date="2016-06-22T13:49:32Z" target-language="de" product-name="sic_address">
 		<header/>
 		<body>
+			<trans-unit id="label_update_title">
+				<target>sic_address wurde aktualisiert !</target>
+			</trans-unit>
+			<trans-unit id="label_update_message">
+				<target>Der Generierungsprozess muss erneut durchgeführt werden!</target>
+			</trans-unit>
 			<trans-unit id="tx_sicaddress_domain_model_address_title">
 				<target>Adressen</target>
 			</trans-unit>
diff --git a/Resources/Private/Language/locallang.xlf b/Resources/Private/Language/locallang.xlf
@@ -3,6 +3,12 @@
 	<file source-language="en" datatype="plaintext" original="messages" date="2016-06-22T13:49:32Z" product-name="sic_address">
 		<header/>
 		<body>
+			<trans-unit id="label_update_title">
+				<source>sic_address has been updated !</source>
+			</trans-unit>
+			<trans-unit id="label_update_message">
+				<source>Generation process must be run again!</source>
+			</trans-unit>
 			<trans-unit id="tx_sicaddress_domain_model_address_title">
 				<source>Addresses</source>
 			</trans-unit>
diff --git a/Resources/Private/Layouts/Default.html b/Resources/Private/Layouts/Default.html
@@ -1,4 +1,5 @@
 
 <div class="tx-sic-address">
+	<f:flashMessages />
 	<f:render section="main" />
 </div>

Original file line number	Diff line number	Diff line change
`@@ -285,6 +285,8 @@ public function createAction()`
`285`	`285`
`286`	`286`	`$this->updateExtension();`
`287`	`287`	`$this->view->assign("errorMessages", $errorMessages);`
	`288`	`+`
	`289`	`+ if(empty($errorMessages)) @unlink(PATH_typo3conf . 'ext/sic_address/PLEASE_GENERATE');`
`288`	`290`	`}`
`289`	`291`
`290`	`292`