Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lazy=false prop for react-navigation causes RenderTimeoutError and ScreenProfilerNotStartedError #146

Open
5 of 9 tasks
Vadko opened this issue May 5, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Vadko
Copy link

Vadko commented May 5, 2023

Current behavior

using "lazy" as false inside react navigation "screenOptions" navigator leads to RenderTimeoutErrors, because we cant determine where and how should we start timer

ERROR ScreenProfilerNotStartedError: TaskQueue: Error with task : No previous state was found for screen 'xyz' with componentInstanceId 0. This probably means that the navigation-start event was never recorded, while a subsequent render flow event was (render pass start, data operation profiling, etc.). You seem to have used some profiling API but likely forgot to use the 'useStartProfiler' hook to start the flow. Read the usage here: https://shopify.github.io/react-native-performance/fundamentals/measuring-render-times., js engine: hermes

Expected behavior

using "lazy" doesnt lead to the timeout

To Reproduce

Platform:

  • iOS
  • Android

Packages

Which packages are affected by the issue?

  • @shopify/react-native-performance
  • @shopify/react-native-performance-lists-profiler
  • flipper-plugin-shopify-react-native-performance
  • @shopify/react-native-performance-navigation
  • @shopify/react-native-performance-navigation-bottom-tabs
  • @shopify/react-native-performance-navigation-drawer

Environment

  • I've removed the packages that I don't use
package version
@shopify/react-native-performance x.y.z
@shopify/react-native-performance-lists-profiler x.y.z
flipper-plugin-shopify-react-native-performance x.y.z
@shopify/react-native-performance-navigation x.y.z
@shopify/react-native-performance-navigation-bottom-tabs x.y.z
@shopify/react-native-performance-navigation-drawer x.y.z
@react-navigation/native x.y.z
@react-navigation/bottom-tabs x.y.z
@react-navigation/drawer x.y.z
@react-navigation/stack x.y.z
react-native x.y.z
@Vadko Vadko added the bug Something isn't working label May 5, 2023
@Vadko Vadko changed the title lazy prop for react-navigation causes RenderTimeoutError lazy=false prop for react-navigation causes RenderTimeoutError May 5, 2023
@Vadko Vadko changed the title lazy=false prop for react-navigation causes RenderTimeoutError lazy=false prop for react-navigation causes RenderTimeoutError and ScreenProfilerNotStartedError May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant