Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't install react-native-performance-navigation as it depends on [email protected] #113

Open
4 of 10 tasks
hannojg opened this issue Dec 5, 2022 · 0 comments
Open
4 of 10 tasks
Labels
bug Something isn't working

Comments

@hannojg
Copy link

hannojg commented Dec 5, 2022

Current behavior

Steps to reproduce:

npm i @shopify/react-native-performance
#  Installs version >= 4.1.2
npm i @shopify/react-native-performance-navigation
#  Throws an error as seen below

The error output

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: [email protected]
npm ERR! Found: @shopify/[email protected]
npm ERR! node_modules/@shopify/react-native-performance
npm ERR!   @shopify/react-native-performance@"^4.1.2" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @shopify/react-native-performance@"^2.0.0" from @shopify/[email protected]
npm ERR! node_modules/@shopify/react-native-performance-navigation
npm ERR!   @shopify/react-native-performance-navigation@"*" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

Expected behavior

You can install react-native-performance-navigation with the newest version of the main library.
With yarn this would have probably been ignored, but npm is more picky.

To Reproduce

Platform:

  • iOS
  • Android
  • Build tooling

Packages

Which packages are affected by the issue?

  • @shopify/react-native-performance
  • @shopify/react-native-performance-lists-profiler
  • flipper-plugin-shopify-react-native-performance
  • @shopify/react-native-performance-navigation
  • @shopify/react-native-performance-navigation-bottom-tabs
  • @shopify/react-native-performance-navigation-drawer

Environment

  • I've removed the packages that I don't use
package version
@shopify/react-native-performance 4.1.2
@react-navigation/native 6.0.13
@react-navigation/stack 6.3.1
react-native 0.70.4
@hannojg hannojg added the bug Something isn't working label Dec 5, 2022
hannojg added a commit to margelo/expensify-app-fork that referenced this issue Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant