Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Card][LegacyCard] Box shadow incorrectly visible on sm breakpoint #11968

Open
1 task
jesstelford opened this issue May 2, 2024 · 0 comments
Open
1 task

[Card][LegacyCard] Box shadow incorrectly visible on sm breakpoint #11968

jesstelford opened this issue May 2, 2024 · 0 comments

Comments

@jesstelford
Copy link
Contributor

jesstelford commented May 2, 2024 •
edited

Note

Originally posted by @jesstelford in https://github.com/Shopify/web/issues/125730#issuecomment-2089432005

Hmm, this looks like a regression in Polaris; the shadows should be entirely removed on smaller screens 馃

Picking a random Polaris Storybook deployment from Feb 19 2024 shows it rendering correctly:

Screenshot 2024-05-02 at 12 51 30

But this version from April 30 2024 shows the incorrect shadows:
Screenshot 2024-05-02 at 12 50 27

Tasks
Beta Give feedback
@jesstelford jesstelford linked a pull request May 3, 2024 that will close this issue
Update Card and LegacyCard mobile styles #11926
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Card and LegacyCard mobile styles Shopify/polaris
1 participant
@jesstelford