By default, test without Kind (#524)

Author: genevieveluyt

.github/workflows/ci.yml

@@ -22,4 +22,6 @@ jobs:
       - name: Go mod download and go tidy
         run: make setup
       - name: Run tests
+        env:
+          USE_KIND: "true"
         run: make test

README.md

@@ -340,7 +340,7 @@ If you'd like to fix a bug, contribute a feature or just correct a typo, please
 1. Add your forked repo as a fork: `git remote add fork https://github.com/you-are-awesome/kubeaudit`
 1. Create your feature branch: `git checkout -b awesome-new-feature`
 1. Install [Kind](https://kind.sigs.k8s.io/#installation-and-usage)
-1. Run the tests to see everything is working as expected: `make test` (to run tests without Kind: `USE_KIND=false make test`)
+1. Run the tests to see everything is working as expected: `USE_KIND=true make test` (to run tests without Kind: `make test`)
 1. Commit your changes: `git commit -am 'Adds awesome feature'`
 1. Push to the branch: `git push fork`
 1. Sign the [Contributor License Agreement](https://cla.shopify.com/)

internal/test/test.go

@@ -137,7 +137,7 @@ func GetAllFileNames(t *testing.T, directory string) []string {
 
 // UseKind returns true if tests which utilize Kind should run
 func UseKind() bool {
-	return os.Getenv("USE_KIND") != "false"
+	return os.Getenv("USE_KIND") == "true"
 }
 
 func ApplyManifest(t *testing.T, manifestPath, namespace string) {

kubeaudit_test.go

@@ -1,7 +1,6 @@
 package kubeaudit_test
 
 import (
-	"os"
 	"testing"
 
 	"github.com/Shopify/kubeaudit"
@@ -29,7 +28,7 @@ func TestNew(t *testing.T) {
 }
 
 func TestAuditLocal(t *testing.T) {
-	if os.Getenv("USE_KIND") == "false" {
+	if !test.UseKind() {
 		return
 	}
 

test.sh

@@ -5,13 +5,13 @@ set -e
 echo "Starting tests. This may take a while..."
 
 function finish {
-    if [ "$USE_KIND" != "false" ] ; then
+    if [ "$USE_KIND" == "true" ] ; then
         make test-teardown
     fi
 }
 trap finish EXIT
 
-if [ "$USE_KIND" != "false" ] ; then
+if [ "$USE_KIND" == "true" ] ; then
     make test-setup
 fi