Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmark against matomo device detector #1

Open
loevgaard opened this issue Nov 17, 2021 · 2 comments
Open

Add benchmark against matomo device detector #1

loevgaard opened this issue Nov 17, 2021 · 2 comments

Comments

@loevgaard
Copy link
Member

No description provided.

@kaurov
Copy link

kaurov commented Aug 23, 2024

As for me, it is big question for what this library is necessary at all
when Device Detector has isBot() function itself.

Compare their bots lists:
https://github.com/Setono/BotDetectionBundle/blob/master/src/BotDetector/Bots.php
https://github.com/matomo-org/device-detector/blob/master/regexes/bots.yml

@loevgaard
Copy link
Member Author

Hi, @kaurov

I agree. The only thing this does is to optimize the checking for common bots. See https://github.com/Setono/BotDetectionBundle/blob/master/src/BotDetector/BotDetector.php#L49-L50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants