Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix pod security context #177

Open
bartwitkowski opened this issue Nov 4, 2024 · 0 comments
Open

Please fix pod security context #177

bartwitkowski opened this issue Nov 4, 2024 · 0 comments

Comments

@bartwitkowski
Copy link

Hi,

I've talked with some of you during Kubecon '24 in Paris about this but still no changes in your Helm chart.

In short: Current S1 Helm template has Kubernetes pod securityContext settings with lots of defaults.
Those settings are not wrong (the defaults are specified in Kubernetes documentation), but because they are not set explicite thus they are visible, for example, in Microsoft Azure Defender Recommendations.

Could you apply correct securityContext configuration?
If not, then please write why it is bad idea...

Running quick script to determine the configured options give us:

pod: sentinelone-agent

      PodSecurityContext:
        runAsGroup: 1000
        fsGroup: <no value>
        runAsNonRoot: <no value>
        runAsUser: 1000

    container name: s1-agent
    image: xx.azurecr.io/s1agent:23.3.2-x86_64
        allowPrivilegeEscalation: <no value>
        capabilities: map[add:[DAC_OVERRIDE DAC_READ_SEARCH FOWNER SETGID SETUID SYS_ADMIN SYS_PTRACE SYS_RESOURCE SYSLOG SYS_CHROOT CHOWN SYS_MODULE KILL NET_ADMIN NET_RAW] drop:[all]]
        privileged: <no value>
        readOnlyRootFilesystem: <no value>
        runAsGroup: <no value>
        runAsNonRoot: <no value>
        runAsUser: <no value>

pod: sentinelone-helper-86995dddb6-7282t
    PodSecurity Context is not set

    container name: helper
    image: xx.azurecr.io/s1helper:23.3.2-x86_64
        allowPrivilegeEscalation: <no value>
        privileged: <no value>
        readOnlyRootFilesystem: <no value>
        runAsGroup: 1000
        runAsNonRoot: <no value>
        runAsUser: 1000
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant