-
-
Notifications
You must be signed in to change notification settings - Fork 8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[馃殌 Feature]: TracedCommandExecutor
better span name
#13905
Comments
@felixscheinost, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
Hello! |
This issue is looking for contributors. Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested. |
Feature and motivation
We are trying to use OTel tracing to find bottlenecks in the integration tests in our codebase.
We are looking for example for inefficient traversal off large DOM structures, which could be improved using better XPath queries.
Currently all spans generated by Selenium look the same, they all have "command" as the span name. (
selenium/java/src/org/openqa/selenium/remote/TracedCommandExecutor.java
Line 38 in 17d927b
The guide says:
My read is that if following this guide making the span name more special would be a good idea. E.g. "screenshot", "setCurrentWindowSize", "findElement", ...
Usage example
Make spans more readable. Instead of having:
I imagine
as an example.
The text was updated successfully, but these errors were encountered: