Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clearDisplay hardcoded for 4 digits #15

Closed
ja518 opened this issue Mar 7, 2021 · 2 comments
Closed

clearDisplay hardcoded for 4 digits #15

ja518 opened this issue Mar 7, 2021 · 2 comments
Assignees
Labels
Grove_4Digital_Display Label for Grove_4Digital_Display UAY Unassigned yet

Comments

@ja518
Copy link

ja518 commented Mar 7, 2021

While most functions use the number of digits specified in DIGITS, clearDisplay writes 0x7f only to digits 0x00~0x03.
This creates artifacts when the number of digits is bigger than 4.

--> Replaced with:
void TM1637::clearDisplay(void) {
for (int i = 0; i < DIGITS; i++) {
display(i,0x7f);
}
}

@MatthewJeffson MatthewJeffson added UAY Unassigned yet Grove_4Digital_Display Label for Grove_4Digital_Display labels Oct 9, 2024
@Lesords Lesords self-assigned this Oct 15, 2024
@Lesords Lesords assigned ackPeng and unassigned Lesords Oct 16, 2024
@ackPeng
Copy link

ackPeng commented Oct 16, 2024

@ja518 Thank you very much, this is a good suggestion. Do you have any other problems?

@Lesords
Copy link
Contributor

Lesords commented Oct 30, 2024

Hello,

I'm going to close this issue, feel free to re-open it if you have any other questions.

[Autocommentary]

@Lesords Lesords closed this as completed Oct 30, 2024
@github-project-automation github-project-automation bot moved this from Todo to Done in Issues and PR Assemble Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Grove_4Digital_Display Label for Grove_4Digital_Display UAY Unassigned yet
Projects
Status: Done
Development

No branches or pull requests

4 participants