Skip to content

Commit e11882a

Browse files
authored
Merge pull request #21 from theikkila/master
Add space before returning statement to prevent invalid syntax
2 parents 3adb6a5 + 2da4b06 commit e11882a

File tree

2 files changed

+21
-3
lines changed

2 files changed

+21
-3
lines changed

psqlextra/compiler.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ def _form_returning(self):
2020
"""Builds the RETURNING part of the query."""
2121

2222
qn = self.connection.ops.quote_name
23-
return 'RETURNING %s' % qn(self.query.model._meta.pk.name)
23+
return ' RETURNING %s' % qn(self.query.model._meta.pk.name)
2424

2525

2626
class PostgresInsertCompiler(SQLInsertCompiler):

tests/test_signals.py

Lines changed: 20 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,10 @@ def mock_signal_handler(signal):
1616
"""
1717

1818
model = get_fake_model({
19-
'title': models.CharField(max_length=255)
20-
})
19+
'title': models.CharField(max_length=255),
20+
'flag': models.BooleanField(default=False)
21+
})
22+
2123

2224
signal_handler = Mock()
2325
signal.connect(signal_handler, sender=model, weak=False)
@@ -108,3 +110,19 @@ def test_query_set_update():
108110
assert signal_handler.call_count == 2
109111
assert signal_handler.call_args_list[0][1]['pk'] == instance_1.pk
110112
assert signal_handler.call_args_list[1][1]['pk'] == instance_2.pk
113+
114+
115+
def test_query_set_update_boolean():
116+
"""Tests whether the update signal is emitted
117+
for each row that has been updated with boolean values."""
118+
119+
model, signal_handler = mock_signal_handler(signals.update)
120+
121+
instance_1 = model.objects.create(title='beer')
122+
instance_2 = model.objects.create(title='more boar')
123+
124+
model.objects.all().update(flag=True)
125+
126+
assert signal_handler.call_count == 2
127+
assert signal_handler.call_args_list[0][1]['pk'] == instance_1.pk
128+
assert signal_handler.call_args_list[1][1]['pk'] == instance_2.pk

0 commit comments

Comments
 (0)