Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EchoPrefs part 1: Backgrounds, Languages and Quirks (Not done yet, but for the curious and for the watchers) #14

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Ms-Mee
Copy link
Contributor

@Ms-Mee Ms-Mee commented Mar 13, 2024

About The Pull Request

This PR changes some aspects of the preferences UI and adds 2 new tabs: One for a new addition, backgrounds, and one for quirks. This should also include some changes to languages and possibly eventually also records, likely in another PR, although neither are implemented currently. If it takes too long I'll just remove them from this PR and postpone their addition.

Some files have not had some content removed just to serve as a bit of an example until later.

Tasklist:

  • Quirk UI
  • Variable quirks/quirk option selection
  • Replacement of some(Phobia, Junkie, Smoker) current quirks with variable versions.
  • Savefile changes, including replacing junkie with the new quirk Addicted (forgot but there's other stuff too)
  • Backgrounds tab
  • Culture files and definitions
  • Basic echo lore
  • Language UI
  • Actually grant starting languages
  • Rework languages to not have starting languages depend on species but entirely on selected prefs languages, add cultural languages if applicable, remove or otherwise rework some languages
  • Species(or really limb and organ)-specific modes of communication (such as wing buzzing for buzzwords) rather than specific languages tied to species, that one also chooses to learn from prefs
  • Baseline for echo accents, language-specific accents (might be a nightmare might not who knows, although manual accents are somewhat superior they're hard to get used to. To be a bit clearer, choosing different accents for each language like say talking like a mobster in common and a cowboy in kalixcian common)
  • Change check regex so all tests pass

The baseline for backgrounds is the backgrounds tab from the horizon codebase, which no longer exists proper. See my branch of a branch of it if you would like to see it's commit history and such.

Why It's Good For The Game

Backgrounds and languages: Echo would benefit from having lore be present in-game, especially such that people's connections and backgrounds can be identified, when complete this PR would ideally be a baseline framework for adding Echo's locations, factions and cultures as the lore team writes entries for them, with a few examples for each entry type alongside the generic ones.
Quirks: Improvement to UI, added customization.

Changelog

🆑
add: Backgrounds, backgrounds tab, variable quirks
code: Character Appearance, Gear and Setup moved to subtabs, quirks moved to a subtab with changed interface.
code: Variable quirks, phobia is picked on the quirk tab, addiction and smoker reworked to be variable quirks with a few options.
/:cl:

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Jul 19, 2024

This PR tempts me like a siren in the waves, but I have more important things going on

Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@TheNeoGamer42
Copy link
Contributor

conflicts your PR by merging your other

@Ms-Mee
Copy link
Contributor Author

Ms-Mee commented Aug 23, 2024

I'll just have to travel in time a bit, I already planned on doing so which is why I waited to do more stuff
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants