Skip to content

Commit 9a08762

Browse files
authored
Merge pull request #554 from SebKrantz/development
Remove "na.included" class here for the moment - a temporary tribute …
2 parents 1af9273 + cdfef4d commit 9a08762

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

R/pivot.R

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -80,15 +80,15 @@ melt_all <- function(vd, names, factor, na.rm, labels, check.dups) {
8080
if(factor[2L]) {
8181
label_col <- res[[1L]]
8282
attr(label_col, "levels") <- labs
83-
oldClass(label_col) <- c("factor", "na.included")
83+
oldClass(label_col) <- "factor" # c("factor", "na.included")
8484
} else label_col <- Csv(labs, res[[1L]])
8585
label_col <- list(label_col)
8686
names(label_col) <- if(is.character(labels)) labels else "label"
8787
res <- c(res[1L], label_col, res[2L])
8888
}
8989
if(factor[1L]) {
9090
attr(res[[1L]], "levels") <- nam
91-
oldClass(res[[1L]]) <- c("factor", "na.included")
91+
oldClass(res[[1L]]) <- "factor" # c("factor", "na.included")
9292
} else if(length(labels)) res[[1L]] <- Csv(nam, res[[1L]])
9393
res
9494
}
@@ -185,7 +185,7 @@ pivot <- function(data,
185185
if(factor[2L]) {
186186
label_col <- value_cols[[1L]]
187187
attr(label_col, "levels") <- labs
188-
oldClass(label_col) <- c("factor", "na.included")
188+
oldClass(label_col) <- "factor" # c("factor", "na.included")
189189
} else label_col <- Csv(labs, value_cols[[1L]])
190190
label_col <- list(label_col)
191191
if(is.list(labels)) { # Setting new labels...
@@ -212,7 +212,7 @@ pivot <- function(data,
212212
}
213213
if(factor[1L]) {
214214
attr(value_cols[[1L]], "levels") <- nam[values]
215-
oldClass(value_cols[[1L]]) <- c("factor", "na.included")
215+
oldClass(value_cols[[1L]]) <- "factor" # c("factor", "na.included")
216216
} else if(length(labels)) value_cols[[1L]] <- duplAttributes(Csv(nam[values], value_cols[[1L]]), value_cols[[1L]])
217217
res <- c(id_cols, value_cols)
218218
}
@@ -397,7 +397,7 @@ pivot <- function(data,
397397
if(factor[2L]) {
398398
label_col <- value_cols[[1L]]
399399
attr(label_col, "levels") <- labs
400-
oldClass(label_col) <- c("factor", "na.included")
400+
oldClass(label_col) <- "factor" # c("factor", "na.included")
401401
} else label_col <- Csv(labs, value_cols[[1L]])
402402
label_col <- list(label_col)
403403
names(label_col) <- labels[[2L]]
@@ -406,7 +406,7 @@ pivot <- function(data,
406406

407407
if(factor[1L]) {
408408
attr(value_cols[[1L]], "levels") <- namv
409-
oldClass(value_cols[[1L]]) <- c("factor", "na.included")
409+
oldClass(value_cols[[1L]]) <- "factor" # c("factor", "na.included")
410410
} else if(save_labels) value_cols[[1L]] <- Csv(namv, value_cols[[1L]])
411411

412412
if(length(new_labels <- labels[[3L]])) {

man/GGDC10S.Rd

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,8 +46,6 @@ namlab(GGDC10S, class = TRUE)
4646
# aperm(qsu(GGDC10S, ~ Variable, ~ Variable + Country, vlabels = TRUE))
4747
\donttest{
4848
library(ggplot2)
49-
# Solves https://github.com/r-lib/vctrs/issues/1888 (not a collapse problem)
50-
vec_ptype2.factor.factor <- function(x, y, ...) x
5149

5250
## World Regions Structural Change Plot
5351

0 commit comments

Comments
 (0)