Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanly shutdown / finish encoding when interrupting the recording externally via GNOME Shell's video recording indicator button #287

Open
nekohayo opened this issue Mar 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@nekohayo
Copy link

Affected version

  • io.github.seadve.Kooha 2.2.4
  • Flatpak: true
  • Experimental: false
  • Distribution: GNOME 45 (Flatpak runtime)
  • Desktop Session: gnome
  • Display Server: wayland
  • GTK 4.12.5
  • Libadwaita 1.4.3
  • GStreamer 1.22.10
  • Pipewire 0.3.83

Bug summary

When interrupting recording via GNOME Shell, Kooha should still be able to finish encoding a valid file.

Steps to reproduce

  1. Start recording with Kooha
  2. Click GNOME Shell's orange video recording indicator button in the system menu (top-right corner), as it is faster / more convenient than fishing out Kooha's window from within the pile of windows.

Current result: Kooha outputs a broken video file in this situation.

Expected result: if possible, I would still expect Kooha to finalize the recording into a playable video file (after all, this works fine with GNOME Shell's built-in video recorder), instead of a corrupt file.

@SeaDve
Copy link
Owner

SeaDve commented Mar 11, 2024

I have attempted to fix this before, but haven't spent enough time. :D It's harder than I thought; a fix in pipewire may be needed upstream.

@SeaDve SeaDve added the bug Something isn't working label Mar 11, 2024
@SeaDve SeaDve added this to the 2.3.0 milestone Mar 11, 2024
@SeaDve SeaDve removed this from the 2.3.0 milestone Mar 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants