syntax: ValidName should return false on ""

An empty string isn't a valid name. For example, one cannot do any of
the following:

	declare =bar
	echo ${}

This wasn't a big problem in the parser, as it already knew whether or
not it had a non-empty literal. But other users of ValidName, like
interp, would get bugs because of the missing empty string check.

Author: mvdan

syntax/parser.go

@@ -1473,6 +1473,9 @@ func (p *Parser) backquoteEnd() bool {
 
 // ValidName returns whether val is a valid name as per the POSIX spec.
 func ValidName(val string) bool {
+	if val == "" {
+		return false
+	}
 	for i, r := range val {
 		switch {
 		case 'a' <= r && r <= 'z':

syntax/parser_test.go

@@ -2110,3 +2110,28 @@ func TestParseStmtsStopAt(t *testing.T) {
 		t.Run(fmt.Sprintf("%02d", i), singleParse(p, c.in, want))
 	}
 }
+
+func TestValidName(t *testing.T) {
+	t.Parallel()
+	tests := []struct {
+		name string
+		in   string
+		want bool
+	}{
+		{"Empty", "", false},
+		{"Simple", "foo", true},
+		{"MixedCase", "Foo", true},
+		{"Underscore", "_foo", true},
+		{"NumberPrefix", "3foo", false},
+		{"NumberSuffix", "foo3", true},
+	}
+	for _, tc := range tests {
+		t.Run(tc.name, func(t *testing.T) {
+			got := ValidName(tc.in)
+			if got != tc.want {
+				t.Fatalf("ValidName(%q) got %t, wanted %t",
+					tc.in, got, tc.want)
+			}
+		})
+	}
+}