checkers: recognize NOTE pattern in deprecatedComment (go-critic#770)

Fixes go-critic#643 Signed-off-by: Iskander Sharipov <[email protected]>
ScrambleShell · Jan 16, 2019 · d8d0ee4 · d8d0ee4
1 parent 09582e2
commit d8d0ee4
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 0 deletions.
diff --git a/checkers/deprecatedComment_checker.go b/checkers/deprecatedComment_checker.go
@@ -28,6 +28,7 @@ func FuncOld() int`
 			regexp.MustCompile(`(?i)this (?:function|type) is deprecated`),
 			regexp.MustCompile(`(?i)deprecated[.!]? use \S* instead`),
 			regexp.MustCompile(`(?i)\[\[deprecated\]\].*`),
+			regexp.MustCompile(`(?i)note: deprecated\b.*`),
 			// TODO(quasilyte): more of these?
 		}
 

diff --git a/checkers/testdata/deprecatedComment/negative_tests.go b/checkers/testdata/deprecatedComment/negative_tests.go
@@ -14,3 +14,6 @@ type deprecated struct{}
 
 // Derpecated is a type name.
 type Derpecated struct{}
+
+// Note that this one is not deprecated.
+func f() {}
diff --git a/checkers/testdata/deprecatedComment/positive_tests.go b/checkers/testdata/deprecatedComment/positive_tests.go
@@ -129,3 +129,13 @@ var (
 	// DERPecate: ...
 	_ = 0
 )
+
+/*! the proper format is `Deprecated: <text>` */
+// NOTE: Deprecated. Use bar instead.
+func foo1() {
+}
+
+/*! the proper format is `Deprecated: <text>` */
+// NOTE: Deprecated.
+func foo2() {
+}