Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OTHER] Adopt repo-review for tephi #155

Open
3 tasks
ESadek-MO opened this issue Sep 30, 2024 · 1 comment
Open
3 tasks

[OTHER] Adopt repo-review for tephi #155

ESadek-MO opened this issue Sep 30, 2024 · 1 comment
Assignees
Milestone

Comments

@ESadek-MO
Copy link
Contributor

ESadek-MO commented Sep 30, 2024

❓ Other

Adopt and align tephi with repo review, as in cf-units.

Tasks

@ESadek-MO ESadek-MO added this to the v0.4.0 milestone Oct 24, 2024
@ESadek-MO ESadek-MO self-assigned this Nov 4, 2024
@ESadek-MO
Copy link
Contributor Author

I think we should aim to include:

  • PY005: - Has tests folder
  • PP003: - Does not list wheel as a build-dep
  • PP301: - Has pytest in project
  • PP309: - Filter warnings specified
  • PC110: - Uses black or ruff-format
  • PC140: - Uses a type checker
  • PC160: - Uses a spell checker
  • PC170: - Uses PyGrep hooks (only needed if rST present)
  • PC190: - Uses Ruff
  • PC901: - Custom pre-commit CI message
  • RF001: - Has Ruff config

With these being nice to haves:

  • PP304: - Sets the log level in pytest
  • PP305: - Specifies xfail_strict
  • PP306: - Specifies strict config
  • PP307: - Specifies strict markers
  • GH212: - Require GHA update grouping
  • PC180: - Uses a markdown formatter
  • MY100: - Uses MyPy (pyproject config)

@bjlittle that sound about right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant