Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance Shift(s): de4843c4 #6143

Open
github-actions bot opened this issue Sep 7, 2024 · 3 comments
Open

Performance Shift(s): de4843c4 #6143

github-actions bot opened this issue Sep 7, 2024 · 3 comments
Assignees
@trexfeathers
Labels
Bot A bot generated issue/pull-request Type: Performance

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2024

Benchmark comparison has identified performance shifts at:

Please review the report below and take corrective/congratulatory action as appropriate :slightly_smiling_face:

⏱️ Performance Benchmark Report: de4843c

Performance shifts 
| Change   | Before [fa8a4166] <main~1>   | After [de4843c4] <main>   |   Ratio | Benchmark (Parameter)                                                             |
|----------|------------------------------|---------------------------|---------|-----------------------------------------------------------------------------------|
| +        | 365±2ms                      | 547±5ms                   |    1.5  | load.StructuredFF.time_structured_load((2, 2, 1000), True)                        |
| +        | 14.2±0.1ms                   | 17.4±0.4ms                |    1.23 | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(50) |
Full benchmark results 

Benchmarks that have stayed the same:

| Change   | Before [fa8a4166] <main~1>   | After [de4843c4] <main>   |   Ratio | Benchmark (Parameter)                                                                       |
|----------|------------------------------|---------------------------|---------|---------------------------------------------------------------------------------------------|
|          | 53.5±1ms                     | 58.0±0.6ms                |    1.08 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(False)                              |
|          | 54.2±0.8ms                   | 58.6±1ms                  |    1.08 | aggregate_collapse.Aggregation.time_aggregated_by_COUNT(True)                               |
|          | 191±2ms                      | 207±2ms                   |    1.09 | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(False)                    |
|          | 195±4ms                      | 206±2ms                   |    1.06 | aggregate_collapse.Aggregation.time_aggregated_by_FAST_PERCENTILE(True)                     |
|          | 36.6±0.5ms                   | 37.6±0.5ms                |    1.03 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(False)                              |
|          | 37.0±0.4ms                   | 38.3±0.6ms                |    1.04 | aggregate_collapse.Aggregation.time_aggregated_by_GMEAN(True)                               |
|          | 37.0±0.5ms                   | 37.4±0.5ms                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(False)                              |
|          | 37.3±0.3ms                   | 38.7±0.6ms                |    1.04 | aggregate_collapse.Aggregation.time_aggregated_by_HMEAN(True)                               |
|          | 46.9±0.8ms                   | 49.7±0.8ms                |    1.06 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(False)                                |
|          | 47.5±1ms                     | 50.8±0.5ms                |    1.07 | aggregate_collapse.Aggregation.time_aggregated_by_MAX(True)                                 |
|          | 121±1ms                      | 137±1ms                   |    1.13 | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(False)                            |
|          | 122±1ms                      | 138±2ms                   |    1.13 | aggregate_collapse.Aggregation.time_aggregated_by_MAX_RUN(True)                             |
|          | 51.1±0.7ms                   | 54.7±0.6ms                |    1.07 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(False)                               |
|          | 51.7±0.6ms                   | 55.5±0.9ms                |    1.07 | aggregate_collapse.Aggregation.time_aggregated_by_MEAN(True)                                |
|          | 36.4±0.4ms                   | 37.7±0.6ms                |    1.04 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(False)                             |
|          | 37.0±0.4ms                   | 38.4±0.4ms                |    1.04 | aggregate_collapse.Aggregation.time_aggregated_by_MEDIAN(True)                              |
|          | 46.5±0.6ms                   | 50.2±0.4ms                |    1.08 | aggregate_collapse.Aggregation.time_aggregated_by_MIN(False)                                |
|          | 46.9±0.7ms                   | 50.8±0.6ms                |    1.08 | aggregate_collapse.Aggregation.time_aggregated_by_MIN(True)                                 |
|          | 1.33±0.01s                   | 1.34±0.01s                |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(False)                               |
|          | 1.31±0.01s                   | 1.34±0.01s                |    1.02 | aggregate_collapse.Aggregation.time_aggregated_by_PEAK(True)                                |
|          | 681±8ms                      | 687±20ms                  |    1.01 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(False)                         |
|          | 673±10ms                     | 690±10ms                  |    1.03 | aggregate_collapse.Aggregation.time_aggregated_by_PERCENTILE(True)                          |
|          | 34.8±0.4ms                   | 35.8±0.7ms                |    1.03 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(False)                         |
|          | 35.6±0.6ms                   | 37.4±0.4ms                |    1.05 | aggregate_collapse.Aggregation.time_aggregated_by_PROPORTION(True)                          |
|          | 61.5±0.7ms                   | 68.0±1ms                  |    1.11 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(False)                                |
|          | 62.5±0.7ms                   | 67.6±0.8ms                |    1.08 | aggregate_collapse.Aggregation.time_aggregated_by_RMS(True)                                 |
|          | 66.3±1ms                     | 70.3±0.8ms                |    1.06 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(False)                            |
|          | 66.4±0.9ms                   | 70.9±0.6ms                |    1.07 | aggregate_collapse.Aggregation.time_aggregated_by_STD_DEV(True)                             |
|          | 60.6±0.9ms                   | 65.2±0.7ms                |    1.07 | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(False)                           |
|          | 61.5±0.8ms                   | 65.7±0.4ms                |    1.07 | aggregate_collapse.Aggregation.time_aggregated_by_VARIANCE(True)                            |
|          | 19.5±0.3ms                   | 20.0±0.5ms                |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(False)                               |
|          | 23.2±0.4ms                   | 24.1±0.2ms                |    1.04 | aggregate_collapse.Aggregation.time_collapsed_by_COUNT(True)                                |
|          | 130±1ms                      | 141±0.6ms                 |    1.09 | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(False)                     |
|          | 144±1ms                      | 154±0.7ms                 |    1.07 | aggregate_collapse.Aggregation.time_collapsed_by_FAST_PERCENTILE(True)                      |
|          | 17.8±0.7ms                   | 17.8±0.3ms                |    1    | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(False)                               |
|          | 21.7±0.4ms                   | 22.1±0.2ms                |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_GMEAN(True)                                |
|          | 17.9±0.4ms                   | 17.8±0.2ms                |    1    | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(False)                               |
|          | 21.6±0.3ms                   | 22.1±0.3ms                |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_HMEAN(True)                                |
|          | 18.5±0.7ms                   | 18.7±0.09ms               |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(False)                                 |
|          | 22.3±0.4ms                   | 22.6±0.3ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MAX(True)                                  |
|          | 34.0±2ms                     | 36.4±1ms                  |    1.07 | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(False)                             |
|          | 37.8±0.9ms                   | 41.0±0.7ms                |    1.09 | aggregate_collapse.Aggregation.time_collapsed_by_MAX_RUN(True)                              |
|          | 19.1±0.5ms                   | 19.4±0.5ms                |    1.01 | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(False)                                |
|          | 22.6±0.7ms                   | 23.4±0.3ms                |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_MEAN(True)                                 |
|          | 18.9±0.5ms                   | 18.7±0.4ms                |    0.99 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(False)                              |
|          | 22.2±0.5ms                   | 22.8±0.1ms                |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_MEDIAN(True)                               |
|          | 18.5±0.5ms                   | 18.5±0.4ms                |    1    | aggregate_collapse.Aggregation.time_collapsed_by_MIN(False)                                 |
|          | 22.5±0.5ms                   | 23.1±0.9ms                |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_MIN(True)                                  |
|          | 553±2ms                      | 573±3ms                   |    1.04 | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(False)                                |
|          | 563±7ms                      | 585±6ms                   |    1.04 | aggregate_collapse.Aggregation.time_collapsed_by_PEAK(True)                                 |
|          | 149±2ms                      | 159±1ms                   |    1.07 | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(False)                          |
|          | 166±2ms                      | 179±2ms                   |    1.08 | aggregate_collapse.Aggregation.time_collapsed_by_PERCENTILE(True)                           |
|          | 17.5±0.2ms                   | 17.5±0.5ms                |    1    | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(False)                          |
|          | 21.5±0.3ms                   | 22.0±0.3ms                |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_PROPORTION(True)                           |
|          | 20.8±0.8ms                   | 21.6±0.5ms                |    1.04 | aggregate_collapse.Aggregation.time_collapsed_by_RMS(False)                                 |
|          | 24.6±0.4ms                   | 26.1±0.6ms                |    1.06 | aggregate_collapse.Aggregation.time_collapsed_by_RMS(True)                                  |
|          | 20.7±0.4ms                   | 21.3±0.3ms                |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(False)                             |
|          | 24.3±0.4ms                   | 25.5±0.3ms                |    1.05 | aggregate_collapse.Aggregation.time_collapsed_by_STD_DEV(True)                              |
|          | 20.2±1ms                     | 20.6±0.2ms                |    1.02 | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(False)                            |
|          | 24.1±0.8ms                   | 24.9±0.2ms                |    1.03 | aggregate_collapse.Aggregation.time_collapsed_by_VARIANCE(True)                             |
|          | 83.0±1ms                     | 92.6±2ms                  |    1.12 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(False)                     |
|          | 84.3±0.8ms                   | 92.9±1ms                  |    1.1  | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_MEAN(True)                      |
|          | 95.3±0.9ms                   | 106±1ms                   |    1.12 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(False)                      |
|          | 95.4±2ms                     | 107±0.6ms                 |    1.12 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_RMS(True)                       |
|          | 57.9±0.7ms                   | 63.0±0.7ms                |    1.09 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(False)                      |
|          | 59.1±0.9ms                   | 63.6±0.7ms                |    1.08 | aggregate_collapse.WeightedAggregation.time_w_aggregated_by_SUM(True)                       |
|          | 28.9±0.5ms                   | 30.3±0.4ms                |    1.05 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(False)                      |
|          | 32.6±0.3ms                   | 34.0±0.4ms                |    1.04 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_MEAN(True)                       |
|          | 31.2±0.8ms                   | 32.1±0.5ms                |    1.03 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(False)                       |
|          | 34.3±0.8ms                   | 36.0±0.4ms                |    1.05 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_RMS(True)                        |
|          | 25.5±0.5ms                   | 25.3±0.2ms                |    0.99 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(False)                       |
|          | 29.0±0.3ms                   | 29.5±0.4ms                |    1.02 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_SUM(True)                        |
|          | 326±3ms                      | 332±4ms                   |    1.02 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(False)               |
|          | 345±4ms                      | 356±4ms                   |    1.03 | aggregate_collapse.WeightedAggregation.time_w_collapsed_by_WPERCENTILE(True)                |
|          | 1.11±0.01ms                  | 1.13±0.01ms               |    1.02 | cube.CubeCreation.time_create(False, 'construct')                                           |
|          | 398±5μs                      | 402±9μs                   |    1.01 | cube.CubeCreation.time_create(False, 'instantiate')                                         |
|          | 959±10μs                     | 945±10μs                  |    0.99 | cube.CubeCreation.time_create(True, 'construct')                                            |
|          | 586±6μs                      | 584±7μs                   |    1    | cube.CubeCreation.time_create(True, 'instantiate')                                          |
|          | 221±4ms                      | 233±3ms                   |    1.06 | cube.CubeEquality.time_equality(False, False, 'all_equal')                                  |
|          | 112±1ms                      | 122±1ms                   |    1.09 | cube.CubeEquality.time_equality(False, False, 'coord_inequality')                           |
|          | 233±3ms                      | 244±4ms                   |    1.05 | cube.CubeEquality.time_equality(False, False, 'data_inequality')                            |
|          | 16.6±0.2μs                   | 16.7±0.2μs                |    1.01 | cube.CubeEquality.time_equality(False, False, 'metadata_inequality')                        |
|          | 304±5ms                      | 323±4ms                   |    1.06 | cube.CubeEquality.time_equality(False, True, 'all_equal')                                   |
|          | 201±2ms                      | 215±3ms                   |    1.07 | cube.CubeEquality.time_equality(False, True, 'coord_inequality')                            |
|          | 315±5ms                      | 337±4ms                   |    1.07 | cube.CubeEquality.time_equality(False, True, 'data_inequality')                             |
|          | 16.9±0.3μs                   | 16.9±0.3μs                |    1    | cube.CubeEquality.time_equality(False, True, 'metadata_inequality')                         |
|          | 221±3ms                      | 235±2ms                   |    1.06 | cube.CubeEquality.time_equality(True, False, 'all_equal')                                   |
|          | 112±1ms                      | 124±1ms                   |    1.1  | cube.CubeEquality.time_equality(True, False, 'coord_inequality')                            |
|          | 232±5ms                      | 246±2ms                   |    1.06 | cube.CubeEquality.time_equality(True, False, 'data_inequality')                             |
|          | 52.9±0.9μs                   | 54.2±0.6μs                |    1.02 | cube.CubeEquality.time_equality(True, False, 'metadata_inequality')                         |
|          | 304±6ms                      | 325±3ms                   |    1.07 | cube.CubeEquality.time_equality(True, True, 'all_equal')                                    |
|          | 200±1ms                      | 217±3ms                   |    1.08 | cube.CubeEquality.time_equality(True, True, 'coord_inequality')                             |
|          | 311±7ms                      | 335±4ms                   |    1.08 | cube.CubeEquality.time_equality(True, True, 'data_inequality')                              |
|          | 54.4±0.6μs                   | 55.1±0.5μs                |    1.01 | cube.CubeEquality.time_equality(True, True, 'metadata_inequality')                          |
|          | 775±20μs                     | 799±3μs                   |    1.03 | import_iris.Iris.time__concatenate                                                          |
|          | 182±3μs                      | 180±2μs                   |    0.99 | import_iris.Iris.time__constraints                                                          |
|          | 111±1μs                      | 111±1μs                   |    1    | import_iris.Iris.time__data_manager                                                         |
|          | 93.5±1μs                     | 93.3±0.8μs                |    1    | import_iris.Iris.time__deprecation                                                          |
|          | 137±2μs                      | 137±2μs                   |    1    | import_iris.Iris.time__lazy_data                                                            |
|          | 890±8μs                      | 918±7μs                   |    1.03 | import_iris.Iris.time__merge                                                                |
|          | 76.6±0.6μs                   | 76.0±0.7μs                |    0.99 | import_iris.Iris.time__representation                                                       |
|          | 484±10μs                     | 486±5μs                   |    1    | import_iris.Iris.time_analysis                                                              |
|          | 140±2μs                      | 139±0.9μs                 |    0.99 | import_iris.Iris.time_analysis__area_weighted                                               |
|          | 109±2μs                      | 110±0.8μs                 |    1.01 | import_iris.Iris.time_analysis__grid_angles                                                 |
|          | 241±2μs                      | 242±2μs                   |    1.01 | import_iris.Iris.time_analysis__interpolation                                               |
|          | 186±2μs                      | 185±2μs                   |    1    | import_iris.Iris.time_analysis__regrid                                                      |
|          | 112±2μs                      | 111±0.5μs                 |    0.99 | import_iris.Iris.time_analysis__scipy_interpolate                                           |
|          | 137±2μs                      | 140±3μs                   |    1.02 | import_iris.Iris.time_analysis_calculus                                                     |
|          | 326±3μs                      | 329±3μs                   |    1.01 | import_iris.Iris.time_analysis_cartography                                                  |
|          | 94.0±1μs                     | 93.6±1μs                  |    1    | import_iris.Iris.time_analysis_geomerty                                                     |
|          | 217±2μs                      | 218±4μs                   |    1.01 | import_iris.Iris.time_analysis_maths                                                        |
|          | 96.7±0.7μs                   | 96.6±0.9μs                |    1    | import_iris.Iris.time_analysis_stats                                                        |
|          | 174±2μs                      | 173±2μs                   |    1    | import_iris.Iris.time_analysis_trajectory                                                   |
|          | 306±4μs                      | 303±2μs                   |    0.99 | import_iris.Iris.time_aux_factory                                                           |
|          | 83.5±1μs                     | 82.7±0.8μs                |    0.99 | import_iris.Iris.time_common                                                                |
|          | 161±4μs                      | 161±2μs                   |    1    | import_iris.Iris.time_common_lenient                                                        |
|          | 1.32±0.02ms                  | 1.34±0.03ms               |    1.02 | import_iris.Iris.time_common_metadata                                                       |
|          | 132±1μs                      | 131±1μs                   |    1    | import_iris.Iris.time_common_mixin                                                          |
|          | 1.17±0.01ms                  | 1.18±0.02ms               |    1.01 | import_iris.Iris.time_common_resolve                                                        |
|          | 198±3μs                      | 200±0.8μs                 |    1.01 | import_iris.Iris.time_config                                                                |
|          | 123±1μs                      | 123±0.7μs                 |    1    | import_iris.Iris.time_coord_categorisation                                                  |
|          | 366±3μs                      | 366±1μs                   |    1    | import_iris.Iris.time_coord_systems                                                         |
|          | 754±8μs                      | 760±9μs                   |    1.01 | import_iris.Iris.time_coords                                                                |
|          | 675±8μs                      | 677±4μs                   |    1    | import_iris.Iris.time_cube                                                                  |
|          | 230±4μs                      | 225±3μs                   |    0.98 | import_iris.Iris.time_exceptions                                                            |
|          | 76.5±0.5μs                   | 76.5±0.4μs                |    1    | import_iris.Iris.time_experimental                                                          |
|          | 184±1μs                      | 186±3μs                   |    1.01 | import_iris.Iris.time_fileformats                                                           |
|          | 252±3μs                      | 250±2μs                   |    0.99 | import_iris.Iris.time_fileformats__ff                                                       |
|          | 2.70±0.02ms                  | 2.69±0.01ms               |    0.99 | import_iris.Iris.time_fileformats__ff_cross_references                                      |
|          | 79.2±0.7μs                   | 79.0±0.3μs                |    1    | import_iris.Iris.time_fileformats__pp_lbproc_pairs                                          |
|          | 114±0.4μs                    | 115±0.9μs                 |    1.01 | import_iris.Iris.time_fileformats_abf                                                       |
|          | 411±9μs                      | 408±3μs                   |    0.99 | import_iris.Iris.time_fileformats_cf                                                        |
|          | 5.37±0.04ms                  | 5.27±0.06ms               |    0.98 | import_iris.Iris.time_fileformats_dot                                                       |
|          | 74.6±0.6μs                   | 75.1±0.4μs                |    1.01 | import_iris.Iris.time_fileformats_name                                                      |
|          | 257±0.9μs                    | 257±2μs                   |    1    | import_iris.Iris.time_fileformats_name_loaders                                              |
|          | 118±1μs                      | 119±1μs                   |    1    | import_iris.Iris.time_fileformats_netcdf                                                    |
|          | 123±0.8μs                    | 123±0.9μs                 |    0.99 | import_iris.Iris.time_fileformats_nimrod                                                    |
|          | 214±3μs                      | 212±3μs                   |    0.99 | import_iris.Iris.time_fileformats_nimrod_load_rules                                         |
|          | 780±4μs                      | 783±4μs                   |    1    | import_iris.Iris.time_fileformats_pp                                                        |
|          | 184±1μs                      | 182±5μs                   |    0.99 | import_iris.Iris.time_fileformats_pp_load_rules                                             |
|          | 134±2μs                      | 133±2μs                   |    0.99 | import_iris.Iris.time_fileformats_pp_save_rules                                             |
|          | 510±2μs                      | 519±7μs                   |    1.02 | import_iris.Iris.time_fileformats_rules                                                     |
|          | 220±1μs                      | 218±2μs                   |    0.99 | import_iris.Iris.time_fileformats_structured_array_identification                           |
|          | 83.2±0.5μs                   | 83.5±1μs                  |    1    | import_iris.Iris.time_fileformats_um                                                        |
|          | 161±2μs                      | 161±2μs                   |    1    | import_iris.Iris.time_fileformats_um__fast_load                                             |
|          | 137±1μs                      | 138±1μs                   |    1.01 | import_iris.Iris.time_fileformats_um__fast_load_structured_fields                           |
|          | 75.6±0.6μs                   | 76.1±0.5μs                |    1.01 | import_iris.Iris.time_fileformats_um__ff_replacement                                        |
|          | 81.6±0.4μs                   | 81.8±0.6μs                |    1    | import_iris.Iris.time_fileformats_um__optimal_array_structuring                             |
|          | 982±8μs                      | 976±10μs                  |    0.99 | import_iris.Iris.time_fileformats_um_cf_map                                                 |
|          | 135±1μs                      | 135±0.7μs                 |    1    | import_iris.Iris.time_io                                                                    |
|          | 174±3μs                      | 171±1μs                   |    0.98 | import_iris.Iris.time_io_format_picker                                                      |
|          | 229±2μs                      | 228±1μs                   |    1    | import_iris.Iris.time_iris                                                                  |
|          | 127±0.8μs                    | 128±2μs                   |    1.01 | import_iris.Iris.time_iterate                                                               |
|          | 8.45±0.04ms                  | 8.33±0.06ms               |    0.99 | import_iris.Iris.time_palette                                                               |
|          | 2.24±0.04ms                  | 2.25±0.04ms               |    1.01 | import_iris.Iris.time_plot                                                                  |
|          | 104±0.6μs                    | 104±0.9μs                 |    0.99 | import_iris.Iris.time_quickplot                                                             |
|          | 2.22±0.03ms                  | 2.18±0.03ms               |    0.98 | import_iris.Iris.time_std_names                                                             |
|          | 1.76±0.03ms                  | 1.77±0.01ms               |    1    | import_iris.Iris.time_symbols                                                               |
|          | 292±2ms                      | 291±0.8ms                 |    1    | import_iris.Iris.time_tests                                                                 |
|          | 255±3μs                      | 255±3μs                   |    1    | import_iris.Iris.time_third_party_cartopy                                                   |
|          | 4.79±0.04ms                  | 4.85±0.03ms               |    1.01 | import_iris.Iris.time_third_party_cf_units                                                  |
|          | 119±0.9μs                    | 118±0.7μs                 |    0.99 | import_iris.Iris.time_third_party_cftime                                                    |
|          | 2.81±0.03ms                  | 2.84±0.03ms               |    1.01 | import_iris.Iris.time_third_party_matplotlib                                                |
|          | 1.07±0.01ms                  | 1.07±0.01ms               |    1.01 | import_iris.Iris.time_third_party_numpy                                                     |
|          | 172±1μs                      | 171±2μs                   |    1    | import_iris.Iris.time_third_party_scipy                                                     |
|          | 100±1μs                      | 99.9±1μs                  |    1    | import_iris.Iris.time_time                                                                  |
|          | 326±4μs                      | 322±8μs                   |    0.99 | import_iris.Iris.time_util                                                                  |
|          | 73.3±0.4μs                   | 73.2±0.7μs                |    1    | iterate.IZip.time_izip                                                                      |
|          | 8.08±0.05ms                  | 9.05±0.04ms               |    1.12 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'FF')                                  |
|          | 24.5±0.4ms                   | 24.0±0.4ms                |    0.98 | load.LoadAndRealise.time_load((1280, 960, 5), False, 'NetCDF')                              |
|          | 8.93±0.03ms                  | 9.83±0.03ms               |    1.1  | load.LoadAndRealise.time_load((1280, 960, 5), False, 'PP')                                  |
|          | 8.12±0.07ms                  | 9.04±0.06ms               |    1.11 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'FF')                                   |
|          | 22.1±0.3ms                   | 21.7±0.2ms                |    0.98 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'NetCDF')                               |
|          | 8.84±0.07ms                  | 9.89±0.08ms               |    1.12 | load.LoadAndRealise.time_load((1280, 960, 5), True, 'PP')                                   |
|          | 1.35±0.01s                   | 1.55±0.01s                |    1.14 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'FF')                                    |
|          | 21.2±0.2ms                   | 21.8±0.3ms                |    1.03 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'NetCDF')                                |
|          | 1.50±0.01s                   | 1.70±0.01s                |    1.13 | load.LoadAndRealise.time_load((2, 2, 1000), False, 'PP')                                    |
|          | 1.33±0.01s                   | 1.54±0.01s                |    1.16 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'FF')                                     |
|          | 21.0±0.3ms                   | 22.1±0.3ms                |    1.05 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'NetCDF')                                 |
|          | 1.52±0.02s                   | 1.69±0.01s                |    1.12 | load.LoadAndRealise.time_load((2, 2, 1000), True, 'PP')                                     |
|          | 3.96±0.03ms                  | 4.32±0.01ms               |    1.09 | load.LoadAndRealise.time_load((50, 50, 2), False, 'FF')                                     |
|          | 20.2±0.2ms                   | 20.3±0.09ms               |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), False, 'NetCDF')                                 |
|          | 4.21±0.02ms                  | 4.61±0.02ms               |    1.09 | load.LoadAndRealise.time_load((50, 50, 2), False, 'PP')                                     |
|          | 3.95±0.03ms                  | 4.35±0.04ms               |    1.1  | load.LoadAndRealise.time_load((50, 50, 2), True, 'FF')                                      |
|          | 20.2±0.2ms                   | 20.4±0.2ms                |    1.01 | load.LoadAndRealise.time_load((50, 50, 2), True, 'NetCDF')                                  |
|          | 4.20±0.02ms                  | 4.58±0.02ms               |    1.09 | load.LoadAndRealise.time_load((50, 50, 2), True, 'PP')                                      |
|          | 30.7±4ms                     | 32.3±1ms                  |    1.05 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'FF')                               |
|          | 18.9±0.3ms                   | 18.9±0.5ms                |    1    | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'NetCDF')                           |
|          | 13.3±4ms                     | 13.9±4ms                  |    1.05 | load.LoadAndRealise.time_realise((1280, 960, 5), False, 'PP')                               |
|          | 25.6±1ms                     | 25.8±0.9ms                |    1.01 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'FF')                                |
|          | 69.7±2ms                     | 69.9±2ms                  |    1    | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'NetCDF')                            |
|          | 25.3±1ms                     | 25.9±2ms                  |    1.03 | load.LoadAndRealise.time_realise((1280, 960, 5), True, 'PP')                                |
|          | 436±4ms                      | 483±3ms                   |    1.11 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'FF')                                 |
|          | 2.75±0.1ms                   | 2.94±0.1ms                |    1.07 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'NetCDF')                             |
|          | 440±2ms                      | 494±4ms                   |    1.12 | load.LoadAndRealise.time_realise((2, 2, 1000), False, 'PP')                                 |
|          | 441±2ms                      | 497±7ms                   |    1.13 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'FF')                                  |
|          | 2.92±0.04ms                  | 3.03±0.1ms                |    1.04 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'NetCDF')                              |
|          | 445±4ms                      | 505±8ms                   |    1.13 | load.LoadAndRealise.time_realise((2, 2, 1000), True, 'PP')                                  |
|          | 1.59±0.06ms                  | 1.73±0.05ms               |    1.09 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'FF')                                  |
|          | 2.78±0.07ms                  | 2.86±0.07ms               |    1.03 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'NetCDF')                              |
|          | 1.53±0.06ms                  | 1.65±0.06ms               |    1.08 | load.LoadAndRealise.time_realise((50, 50, 2), False, 'PP')                                  |
|          | 1.53±0.06ms                  | 1.72±0.07ms               |    1.13 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'FF')                                   |
|          | 2.81±0.05ms                  | 2.99±0.1ms                |    1.06 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'NetCDF')                               |
|          | 1.61±0.06ms                  | 1.70±0.05ms               |    1.06 | load.LoadAndRealise.time_realise((50, 50, 2), True, 'PP')                                   |
|          | 363±4ms                      | 371±4ms                   |    1.02 | load.ManyVars.time_many_var_load                                                            |
|          | 8.19±0.04ms                  | 9.43±0.2ms                |    1.15 | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'FF')                            |
|          | 9.01±0.1ms                   | 10.1±0.2ms                |    1.12 | load.STASHConstraint.time_stash_constraint((1280, 960, 5), 'PP')                            |
|          | 1.34±0.01s                   | 1.57±0.02s                |    1.17 | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'FF')                              |
|          | 1.52±0.01s                   | 1.73±0.03s                |    1.14 | load.STASHConstraint.time_stash_constraint((2, 2, 1000), 'PP')                              |
|          | 3.98±0.03ms                  | 4.37±0.05ms               |    1.1  | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'FF')                                 |
|          | 4.29±0.04ms                  | 4.74±0.05ms               |    1.1  | load.STASHConstraint.time_stash_constraint((2, 2, 2), 'PP')                                 |
|          | 8.17±0.08ms                  | 9.06±0.08ms               |    1.11 | load.StructuredFF.time_structured_load((1280, 960, 5), False)                               |
|          | 5.07±0.07ms                  | 5.93±0.07ms               |    1.17 | load.StructuredFF.time_structured_load((1280, 960, 5), True)                                |
|          | 1.32±0.01s                   | 1.52±0.02s                |    1.15 | load.StructuredFF.time_structured_load((2, 2, 1000), False)                                 |
|          | 3.96±0.03ms                  | 4.31±0.03ms               |    1.09 | load.StructuredFF.time_structured_load((2, 2, 2), False)                                    |
|          | 3.85±0.02ms                  | 4.19±0.04ms               |    1.09 | load.StructuredFF.time_structured_load((2, 2, 2), True)                                     |
|          | 148±2ms                      | 165±2ms                   |    1.12 | load.TimeConstraint.time_time_constraint(20, 'FF')                                          |
|          | 23.8±0.2ms                   | 23.8±0.3ms                |    1    | load.TimeConstraint.time_time_constraint(20, 'NetCDF')                                      |
|          | 166±2ms                      | 181±3ms                   |    1.09 | load.TimeConstraint.time_time_constraint(20, 'PP')                                          |
|          | 29.6±0.3ms                   | 32.0±0.2ms                |    1.08 | load.TimeConstraint.time_time_constraint(3, 'FF')                                           |
|          | 23.3±0.2ms                   | 23.9±0.2ms                |    1.03 | load.TimeConstraint.time_time_constraint(3, 'NetCDF')                                       |
|          | 31.7±0.2ms                   | 34.3±0.5ms                |    1.08 | load.TimeConstraint.time_time_constraint(3, 'PP')                                           |
|          | 17.5±0.3ms                   | 18.4±0.4ms                |    1.05 | load.ugrid.BasicLoading.time_load_file(1)                                                   |
|          | 41.5±0.9ms                   | 45.0±0.3ms                |    1.08 | load.ugrid.BasicLoading.time_load_file(200000)                                              |
|          | 14.7±0.5ms                   | 14.7±0.1ms                |    1    | load.ugrid.BasicLoading.time_load_mesh(1)                                                   |
|          | 22.3±0.8ms                   | 22.8±0.3ms                |    1.03 | load.ugrid.BasicLoading.time_load_mesh(200000)                                              |
|          | 18.1±0.9ms                   | 18.3±0.4ms                |    1.01 | load.ugrid.BasicLoadingTime.time_load_file(1)                                               |
|          | 20.6±0.5ms                   | 20.8±0.3ms                |    1.01 | load.ugrid.BasicLoadingTime.time_load_file(200000)                                          |
|          | 14.6±0.4ms                   | 14.7±0.2ms                |    1    | load.ugrid.BasicLoadingTime.time_load_mesh(1)                                               |
|          | 17.2±0.7ms                   | 17.1±0.2ms                |    0.99 | load.ugrid.BasicLoadingTime.time_load_mesh(200000)                                          |
|          | 18.8±0.3ms                   | 19.2±0.2ms                |    1.02 | load.ugrid.Callback.time_load_file_callback(1)                                              |
|          | 50.8±0.5ms                   | 55.1±0.8ms                |    1.08 | load.ugrid.Callback.time_load_file_callback(200000)                                         |
|          | 18.8±0.4ms                   | 19.2±0.2ms                |    1.02 | load.ugrid.CallbackTime.time_load_file_callback(1)                                          |
|          | 22.3±0.2ms                   | 22.9±0.3ms                |    1.03 | load.ugrid.CallbackTime.time_load_file_callback(200000)                                     |
|          | 2.72±0.1ms                   | 2.76±0.09ms               |    1.01 | load.ugrid.DataRealisation.time_realise_data(10000)                                         |
|          | 5.36±0.8ms                   | 5.41±0.1ms                |    1.01 | load.ugrid.DataRealisation.time_realise_data(200000)                                        |
|          | 37.4±1ms                     | 36.5±0.3ms                |    0.98 | load.ugrid.DataRealisationTime.time_realise_data(10000)                                     |
|          | 792±6ms                      | 787±4ms                   |    0.99 | load.ugrid.DataRealisationTime.time_realise_data(200000)                                    |
|          | 397±5ms                      | 441±3ms                   |    1.11 | merge_concat.Concatenate.time_concatenate(False)                                            |
|          | 391±3ms                      | 435±2ms                   |    1.11 | merge_concat.Concatenate.time_concatenate(True)                                             |
|          | 109±0.3M                     | 109±0.3M                  |    1    | merge_concat.Concatenate.tracemalloc_concatenate(False)                                     |
|          | 109±0.3M                     | 109±0.3M                  |    1    | merge_concat.Concatenate.tracemalloc_concatenate(True)                                      |
|          | 46.9±0.3ms                   | 51.7±0.4ms                |    1.1  | merge_concat.Merge.time_merge                                                               |
|          | 1.2±0.3M                     | 1.21±0.04M                |    1.01 | merge_concat.Merge.tracemalloc_merge                                                        |
|          | 387±3ns                      | 407±9ns                   |    1.05 | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(50)              |
|          | 255±3ms                      | 257±6ms                   |    1.01 | mesh.utils.regions_combine.CombineRegionsComputeRealData.time_compute_data(500)             |
|          | 647±2k                       | 650±2k                    |    1.01 | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(50)       |
|          | 60±0M                        | 60.1±0M                   |    1    | mesh.utils.regions_combine.CombineRegionsComputeRealData.tracemalloc_compute_data(500)      |
|          | 16.2±0.3ms                   | 19.3±0.3ms                |    1.19 | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(500)          |
|          | 506±90k                      | 518±80k                   |    1.02 | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(50)    |
|          | 12.4±0.09M                   | 12.4±0.09M                |    1    | mesh.utils.regions_combine.CombineRegionsCreateCube.tracemalloc_create_combined_cube(500)   |
|          | 104±0.5ms                    | 108±1ms                   |    1.03 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(50)         |
|          | 689±6ms                      | 699±5ms                   |    1.01 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.time_stream_file2file(500)        |
|          | 1.2±0.03M                    | 1.23±0.03M                |    1.02 | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(50)  |
|          | 96.3±0.05M                   | 96.3±0.04M                |    1    | mesh.utils.regions_combine.CombineRegionsFileStreamedCalc.tracemalloc_stream_file2file(500) |
|          | 66.0±0.5ms                   | 68.3±0.9ms                |    1.04 | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(50)                             |
|          | 649±3ms                      | 653±6ms                   |    1.01 | mesh.utils.regions_combine.CombineRegionsSaveData.time_save(500)                            |
|          | 1.15±0.01M                   | 1.15±0.03M                |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(50)                      |
|          | 96.2±0.02M                   | 96.2±0.03M                |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.tracemalloc_save(500)                     |
|          | 2.1752849999999997           | 2.1752849999999997        |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(50)                  |
|          | 216.01528499999998           | 216.01528499999998        |    1    | mesh.utils.regions_combine.CombineRegionsSaveData.track_filesize_saved(500)                 |
|          | 6.57±0.05ms                  | 6.70±0.03ms               |    1.02 | plot.AuxSort.time_aux_sort                                                                  |
|          | 75.2±5ms                     | 75.4±5ms                  |    1    | regridding.CurvilinearRegridding.time_regrid_pic                                            |
|          | 136±3M                       | 136±3M                    |    1    | regridding.CurvilinearRegridding.tracemalloc_regrid_pic                                     |
|          | 97.7±0.6ms                   | 99.0±0.9ms                |    1.01 | regridding.HorizontalChunkedRegridding.time_regrid_area_w                                   |
|          | 46.3±1ms                     | 48.2±1ms                  |    1.04 | regridding.HorizontalChunkedRegridding.time_regrid_area_w_new_grid                          |
|          | 106±0.06M                    | 106±0.06M                 |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w                            |
|          | 147±0.6M                     | 147±0.02M                 |    1    | regridding.HorizontalChunkedRegridding.tracemalloc_regrid_area_w_new_grid                   |
|          | 4.02±0.04ms                  | 4.53±0.03ms               |    1.13 | save.NetcdfSave.time_netcdf_save_cube(50, False)                                            |
|          | 70.5±0.4ms                   | 74.3±0.7ms                |    1.05 | save.NetcdfSave.time_netcdf_save_cube(50, True)                                             |
|          | 52.5±1ms                     | 53.0±0.4ms                |    1.01 | save.NetcdfSave.time_netcdf_save_cube(600, False)                                           |
|          | 553±4ms                      | 559±3ms                   |    1.01 | save.NetcdfSave.time_netcdf_save_cube(600, True)                                            |
|          | 88.5±2ns                     | 89.4±1ns                  |    1.01 | save.NetcdfSave.time_netcdf_save_mesh(50, False)                                            |
|          | 54.0±0.3ms                   | 56.1±0.3ms                |    1.04 | save.NetcdfSave.time_netcdf_save_mesh(50, True)                                             |
|          | 90.0±1ns                     | 89.3±0.5ns                |    0.99 | save.NetcdfSave.time_netcdf_save_mesh(600, False)                                           |
|          | 488±3ms                      | 493±4ms                   |    1.01 | save.NetcdfSave.time_netcdf_save_mesh(600, True)                                            |
|          | 27.2±0.1k                    | 28.6±0.09k                |    1.05 | save.NetcdfSave.tracemalloc_netcdf_save(50, False)                                          |
|          | 1.72±0.2M                    | 1.6±0.2M                  |    0.93 | save.NetcdfSave.tracemalloc_netcdf_save(50, True)                                           |
|          | 27.2±0.1k                    | 28.6±0.07k                |    1.05 | save.NetcdfSave.tracemalloc_netcdf_save(600, False)                                         |
|          | 208±20M                      | 190±20M                   |    0.92 | save.NetcdfSave.tracemalloc_netcdf_save(600, True)                                          |
|          | 42.3±0.8ms                   | 48.0±1ms                  |    1.14 | stats.PearsonR.time_lazy                                                                    |
|          | 18.8±0.3ms                   | 18.8±0.2ms                |    1    | stats.PearsonR.time_real                                                                    |
|          | 20±0.1M                      | 20±0.05M                  |    1    | stats.PearsonR.tracemalloc_lazy                                                             |
|          | 18.4±0.01M                   | 18.4±0.01M                |    1    | stats.PearsonR.tracemalloc_real                                                             |
|          | 23.2±1ms                     | 23.7±2ms                  |    1.02 | trajectory.TrajectoryInterpolation.time_trajectory_linear                                   |
|          | 60.5±0.6ms                   | 60.4±0.6ms                |    1    | trajectory.TrajectoryInterpolation.time_trajectory_nearest                                  |
|          | 23.3±0.01M                   | 23.3±0.01M                |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_linear                            |
|          | 12.1±0.05M                   | 12.1±0.05M                |    1    | trajectory.TrajectoryInterpolation.tracemalloc_trajectory_nearest                           |

Benchmarks that have got worse:

| Change   | Before [fa8a4166] <main~1>   | After [de4843c4] <main>   |   Ratio | Benchmark (Parameter)                                                             |
|----------|------------------------------|---------------------------|---------|-----------------------------------------------------------------------------------|
| +        | 365±2ms                      | 547±5ms                   |    1.5  | load.StructuredFF.time_structured_load((2, 2, 1000), True)                        |
| +        | 14.2±0.1ms                   | 17.4±0.4ms                |    1.23 | mesh.utils.regions_combine.CombineRegionsCreateCube.time_create_combined_cube(50) |

Generated by GHA run 10746334787
@github-actions github-actions bot added Bot A bot generated issue/pull-request Type: Performance labels Sep 7, 2024
@pp-mo
Copy link
Member

pp-mo commented Sep 10, 2024

This is real + repeatable, but I think for unknown cause following lockfile update. Not due to project code changes, so presumably some change a dependency.
I think we have to just accept this for now.

@pp-mo pp-mo closed this as completed Sep 10, 2024
@trexfeathers
Copy link
Contributor

This is real + repeatable, but I think for unknown cause following lockfile update. Not due to project code changes, so presumably some change a dependency. I think we have to just accept this for now.

We can put entries in the What's New to warn people, IF we think it necessary. The structured load one might be noticeable in some operational work?

@trexfeathers
Copy link
Contributor

I agree with @stephenworsley that it might be worth seeing what happens with a (2, 2, 10000) benchmark - is that still 1.5 times slower?

@trexfeathers trexfeathers reopened this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trexfeathers trexfeathers

Labels
Bot A bot generated issue/pull-request Type: Performance
Projects
🚴 Peloton
Status: Done
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pp-mo @trexfeathers @HGWright