Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should not allow amounts that are not above configured allowed_underpay_amount #92

Open
kristapsk opened this issue Aug 29, 2022 · 0 comments · May be fixed by #96
Open

Should not allow amounts that are not above configured allowed_underpay_amount #92

kristapsk opened this issue Aug 29, 2022 · 0 comments · May be fixed by #96

Comments

@kristapsk
Copy link
Member

This is clearly a bug, introduced when adding allowed_underpay_amount setting. If you specify amount that are not above (1 sat by default), payment will be instantly "confirmed". Should reject same way as when amount is below onchain_dust_limit with only onchain payment method configured. I will look at this!
@kristapsk kristapsk linked a pull request Sep 11, 2022 that will close this issue
Open
@nickfarrow nickfarrow mentioned this issue Dec 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Disallow invoices below allowed_underpay_amount kristapsk/SatSale
1 participant
@kristapsk