Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported currency list consistency across instances #125

Open
benalleng opened this issue Nov 15, 2022 · 1 comment
Open

Supported currency list consistency across instances #125

benalleng opened this issue Nov 15, 2022 · 1 comment

Comments

@benalleng
Copy link
Contributor

benalleng commented Nov 15, 2022

Adding to the config.toml I noticed that all of the supported currencies are included in the order they are added to the list and then sats is appended at the end out of any order that may have been intended by the user. Additionally a user can add sats separately to the list and then see a duplicate sats on the list of currencies.

This issue is based on PR #124 where a discussion came up on how to best organize this input across all instances of Satsale for consistency

I am testing two possible fixes to adjust the user experience for this in config.py line 99

1.An iteration to appends sats if the user did not already input sats as a currency and then organizes the entire list alphabetically
2. Another iteration that organizes the list alphabetically as before but then places sats next to BTC to better demonstrate their relation to one another

@benalleng
Copy link
Contributor Author

Would like some insight on how best to organize this input

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant