Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loading blendshape gltf. #6

Open
wolfviking0 opened this issue May 7, 2018 · 7 comments
Open

Loading blendshape gltf. #6

wolfviking0 opened this issue May 7, 2018 · 7 comments

Comments

@wolfviking0
Copy link

Did you try to load some gltf model with blend shape animation ??

https://github.com/KhronosGroup/glTF-Sample-Models/blob/master/2.0/AnimatedMorphCube/README.md

@SaschaWillems
Copy link
Owner

There's no animation support yet. It's on my list, but no ETA.

@sjfricke
Copy link

sjfricke commented May 13, 2018

@wolfviking0 I actually was in need of blend shapes for another project of mind, I took this project template and adjusted it with implementation for blend shapes
https://github.com/sjfricke/Vulkan-glTF-Morph-Target

@syoyo
Copy link
Contributor

syoyo commented Feb 22, 2020

I have combined Vulkan-glTF-Morph-Target and Vulkan-glTF-PBR(skin) in my internal test app and confirmed it works well.

I'm considering to send a PR to support Morph. Before of it, I have a question.

@sjfricke 's implementation uses SSBO for morph data. Using SSBO for morph data may be flexible, but it makes shader and vulkan data structure complex and codes become difficult to read and maintain(and sometimes it tend to become the source of various bugs(I've faced the out-of-bounds access error for some glTF scene, it was difficult to debug)).

Using VertexAttribute for morph data may be much simpler and clean, but it cannot support sparse morph target data. Also, the number of morph targets may be limited by Vulkan HW limits(although, at least we should be able to support up to 100 morph targets on low-end and mobile GPUs(Mali, Adreno)).

We could also use Texture(or Image) as an morph data storage.

@SaschaWillems how do you think? Do you have any good practice how to implement Morph in Vulkan?

@SaschaWillems
Copy link
Owner

@syoyo: That sounds awesome. And even though code for using SSBOs may be more complex I'd prefer using SSBOs for their flexibility. So feel free to open a PR :)

@syoyo
Copy link
Contributor

syoyo commented Feb 29, 2020

@SaschaWillems OK, will use SSBO. It requires some amount of code and data structure refactoring, so probably PR will be sent around the end of March, 2020

@SaschaWillems
Copy link
Owner

If the SSBO way is too complex or requires too much effort, the other options would be fine too. So feel free to choose the option that suits you best :)

@questgugou
Copy link

good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants