Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase test coverage for Components which are missing few methods #90

Open
preetkaran20 opened this issue Oct 1, 2022 · 6 comments
Open
Labels

Comments

@preetkaran20
Copy link
Member

As part of #56 we have introduced a unit testing framework and now we are looking for adding more unit test for the project.

we are missing few unit tests for https://github.com/SasanLabs/VulnerableApp-facade/tree/main/facade-app/src/Components package.

Have a look at codecov report for finding what all is missing and cover that as part of this issue.
Codecov report: https://app.codecov.io/gh/SasanLabs/VulnerableApp-facade/tree/main/facade-app/src/Components

@ayushsinha25
Copy link

Could you guide me related to this contribution? As I am new to open source.

@preetkaran20
Copy link
Member Author

Hi @ayushsinha25 ,

So we have introduced a unit test framework as part of #56 and there are many unit tests written in the project link. These tests cover many classes but some of the methods are not getting covered as described at https://app.codecov.io/gh/SasanLabs/VulnerableApp-facade/tree/main/facade-app/src/Components.

Now what we need to do is find out what all conditions as not getting covered and cover those via writing the unit test which is adding methods to the already written tests.

example:
https://github.com/SasanLabs/VulnerableApp-facade/blob/main/facade-app/src/test/Header.test.tsx class covers the https://github.com/SasanLabs/VulnerableApp-facade/blob/main/facade-app/src/Components/Header.tsx file but if we look at the report of codecov we find that few conditions are not covered as shown below

image

so we need to cover them.

thanks,
Karan

@trishitchar
Copy link

Hey, can I work on this PR?

@preetkaran20
Copy link
Member Author

@trishitchar @ayushsinha25 There are multiple classes, you guys can pick one of them and work on it. I have assigned to you.

please remove assignment, if not interested.

@trishitchar
Copy link

Can you please elaborate. I'm also a newbie in open source.

@preetkaran20
Copy link
Member Author

please have a look at #90 (comment) and let me know if you have any questions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants